Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Add resource request and limits to Backstage Application and Local DB the Backstage CR Spec #186

Closed
jianrongzhang89 opened this issue Feb 5, 2024 · 5 comments
Labels
jira Issue will be sync'ed to Red Hat JIRA status/duplicate This issue or pull request already exists

Comments

@jianrongzhang89
Copy link
Contributor

This issue to resource request and limits to Backstage Application and Local DB the Backstage CR Spec so that the user can override them via the CR:

  • memory and CPU request and limit to Backstage Application
  • memory and CPU request and limit to Local DB
  • storage size for Local DB
@github-actions github-actions bot added the jira Issue will be sync'ed to Red Hat JIRA label Feb 5, 2024
@gazarenkov gazarenkov added the status/duplicate This issue or pull request already exists label Feb 6, 2024
@gazarenkov
Copy link
Member

@jianrongzhang89
Copy link
Contributor Author

Duplicates https://issues.redhat.com/browse/RHIDP-1153 #185

@#185 is for the resource limits/requests in the default configuration. This one to add the parameters to the Backstage CR.

@gazarenkov
Copy link
Member

Duplicates https://issues.redhat.com/browse/RHIDP-1153 #185

@#185 is for the resource limits/requests in the default configuration. This one to add the parameters to the Backstage CR.

I am not sure if we need to extend CR this way, because:

  • more likely user has no idea about these numbers (it is not easy to estimate) so normally it should be configured by Admin, cluster wide.
  • it can be set up as a part of raw configuration if really needed

@jianrongzhang89
Copy link
Contributor Author

jianrongzhang89 commented Feb 14, 2024

Duplicates https://issues.redhat.com/browse/RHIDP-1153 #185

@#185 is for the resource limits/requests in the default configuration. This one to add the parameters to the Backstage CR.

I am not sure if we need to extend CR this way, because:

  • more likely user has no idea about these numbers (it is not easy to estimate) so normally it should be configured by Admin, cluster wide.
  • it can be set up as a part of raw configuration if really needed

One use case I can think of is this will allow the admins to easily deploy two instances of backstage (one for testing and one for production, for instance) with different resource limits.

In addition, we should consider what happens when the operator version is upgraded which may reset the limits from the new release. If the user configures them in their custom resources, they are less concerned about the upgrades.

@nickboldt
Copy link
Member

As part of the migration from janus-idp to redhat-developer in https://issues.redhat.com/browse/RHIDP-1021, this will be tracked in https://issues.redhat.com/browse/RHIDP-1206

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira Issue will be sync'ed to Red Hat JIRA status/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants