Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all OpenGL dependencies from Core project #54

Closed
japsuu opened this issue Sep 9, 2024 · 0 comments · Fixed by #67
Closed

Remove all OpenGL dependencies from Core project #54

japsuu opened this issue Sep 9, 2024 · 0 comments · Fixed by #67
Assignees
Labels
feature request Request a new feature
Milestone

Comments

@japsuu
Copy link
Owner

japsuu commented Sep 9, 2024

The Core project should not be aware of the active graphics-API implementation. This can be achieved by removing OpenGL related classes from the KorpiEngine.Core project and placing them in their own project (KorpiEngine.OpenGL?).

This way the user can reference the desired Graphics API project from their own project, and when they call Application.Run to initialize the engine, they can pass in a reference to the desired "graphics API instance" implementation (IGraphicsAPI?).

@japsuu japsuu added the feature request Request a new feature label Sep 9, 2024
@japsuu japsuu self-assigned this Sep 9, 2024
@japsuu japsuu moved this to Backlog in KorpiEngine Development Sep 9, 2024
@japsuu japsuu added this to the 1.0 milestone Sep 9, 2024
@japsuu japsuu linked a pull request Sep 23, 2024 that will close this issue
@japsuu japsuu changed the title Remove all OpenGL-related logic from Core project Remove all OpenGL dependencies from Core project Sep 23, 2024
@japsuu japsuu closed this as completed Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in KorpiEngine Development Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant