Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't break tabIndex #168

Open
sfusato opened this issue Mar 8, 2019 · 2 comments
Open

don't break tabIndex #168

sfusato opened this issue Mar 8, 2019 · 2 comments

Comments

@sfusato
Copy link

sfusato commented Mar 8, 2019

I use Pell as part of a form. Using 'TAB' to navigate the form fields, I'm first taken through all the buttons I have initialized for my Pell's instance before arriving in the editor with the cursor.

title_input (press 'TAB' here)
description_input (I expect the cursor to be in the editor and not looping through the icons)

Quick fix: add tabIndex=-1 to the icon's button elements

Currently I have this workaround after Pell is initialized:

document.querySelectorAll('.pell-button').forEach(button => button.setAttribute('tabIndex', "-1"))

but it would be cool to have this built-in.

@caroso1222
Copy link

+1, I'm resorting to these sort of hack as well but it's not clean as I got many pell instances being dynamically created.

@jaredreich
Copy link
Owner

Thanks, slated for V2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants