Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot method broken? #74

Open
edbentinck opened this issue Sep 27, 2018 · 0 comments
Open

Snapshot method broken? #74

edbentinck opened this issue Sep 27, 2018 · 0 comments

Comments

@edbentinck
Copy link

public function snapshot($timestamp)
{
$revision = $this->revisions()
->where('created_at', '<=', Carbon::parse($timestamp))
->first();

The snapshot method always returns the first revision made, regardless of the timestamp. Isn't it supposed to return the most recent revision (i.e. latest()) registered before the given timestamp?

Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant