Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): added component for users to contribute missing search terms #98

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ui): added component for users to contribute missing search terms #98

wants to merge 4 commits into from

Conversation

DevYoma
Copy link
Contributor

@DevYoma DevYoma commented Sep 12, 2024 •
edited by babblebey
Loading

Description

This PR replaces the No Result found with a SearchSuggestionContribution component similar to that of the ContributeCTA astro component

Related Issue

Fixes #68

Screenshots/Screencasts

image

Notes to Reviewer

The SearchSuggestionContribution component is similar to the ContributeCTA component.

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jargons-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 11:31am

babblebey
babblebey reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@babblebey babblebey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @DevYoma,

Beautiful set-up, I had the below looks in mind though, it's a little less/no friction around the search result area, and we consume the ContributionCTA cleanly.

image

This though will require us to debounce the display of the ContributionCTA component for a few secs, to allow smooth render after the no search result is rendered.

What do you think (we can work together on this 😉)???

@DevYoma
Copy link
Contributor Author

DevYoma commented Sep 13, 2024

Yeah, your approach is good. We can work on it together. Now the only thing I want to ask is how we're going to use the ContributeCTA component that's in astro in the search.jsx island

@babblebey
Copy link
Member

how we're going to use the ContributeCTA component that's in astro in the search.jsx island

Oh, that you already done with your introduction of the SearchSuggestionContribution locally in the search island.

Here's what we just have to do next...

  • Edit the SearchSuggestionContribution component content to something we will both agree on
  • Position the SearchSuggestionContribution component in the appropriate place and style to achieve the arrangement
  • Implement a debounce functionality to to achieve the display delay

So, I'll handle the debounce functionality.

I'll let you handle the arrangement; below is a quick video of how I was able to achieve the arrangement within the browser, note the new classes I added etc.. Hopefully this helps

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.09.13-16_24_32.webm

@babblebey babblebey mentioned this pull request Sep 21, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babblebey babblebey babblebey left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Suggestion to Contribute a Word When Search Yields No Results
2 participants
@DevYoma @babblebey