Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key chain delays behaving inconsistently for sources and direct keys #196

Open
E4est opened this issue Dec 31, 2022 · 0 comments · May be fixed by #198
Open

Key chain delays behaving inconsistently for sources and direct keys #196

E4est opened this issue Dec 31, 2022 · 0 comments · May be fixed by #198

Comments

@E4est
Copy link

E4est commented Dec 31, 2022

When setting up a key chain as a service the delay is shorter than when setting up the same key chain as source.

For example (switching the audio output):

service: 'media_player.play_media'

{
	entity_id: media_player.samsung_tv_remote
    	media_content_type: send_key
	media_content_id: 'KEY_HOME+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_LEFT+100+KEY_UP+100+KEY_RIGHT+100+KEY_RIGHT+1000+KEY_ENTER+1000+KEY_HOME'
}

will perform in 5 seconds, while the same key chain would take several seconds for each button press in sources.

This seems to be due to different implementations for parsing the keys for MEDIA_TYPE_KEY or _source_list.

I have a suggestion on how to fix this, I'll create a pull request shortly and reference this issue.

E4est pushed a commit to E4est/ha-samsungtv-tizen that referenced this issue Dec 31, 2022
@E4est E4est linked a pull request Dec 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant