-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why is %20 turned into a space when using Router.navigate? #4059
Comments
Test casevar Backbone = require('backbone');
var router = new Backbone.Router();
Backbone.history.start();
router.navigate('space%20space'); Expected resultUrl looks something like Actual resultUrl looks like Why this is a problemThis breaks URLs when copy pasting them, etc, and in general is inconsistent behavior, because none of the other URLencoded chars get decoded. How to see it for yourselfgit clone [email protected]:davis/backbone-router-test.git
cd backbone-router-test
open index.html |
Not sure but are you using jQuery 3 under the hood? It might be it: https://jquery.com/upgrade-guide/3.0/#breaking-change-jquery-param-no-longer-converts-20-to-a-plus-sign |
Looks like #4025 |
Any plan on releasing a version containing #4025 fix? 1.3.4 maybe? Thanks! |
Seems to have been fixed in #4026. |
This issue has been here for a while, I couldn't find anything issues, so I went ahead and made a test repo. Was hoping you could provide some insight as to why %20s are being turned into spaces.
https://github.com/davis/backbone-router-test
Thanks!
The text was updated successfully, but these errors were encountered: