Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize zeroArray function #158

Open
kravets-levko opened this issue Jun 26, 2019 · 1 comment
Open

Optimize zeroArray function #158

kravets-levko opened this issue Jun 26, 2019 · 1 comment

Comments

@kravets-levko
Copy link

kravets-levko commented Jun 26, 2019 •
edited
Loading

Hi @jasondavies! I tried to use d3-cloud with a quite large board size (approx. 20000*20000), and noticed that there is a significant lag even when using only few words. The slowest part is zeroArray function. Here are few possible optimizations for it - https://jsperf.com/d3-cloud/ (all of them work fine). Should I submit a fix for it, or you prefer to do it yourself? Thanks!

image
image
image
@Harpush
Copy link

Harpush commented Aug 8, 2023

@jasondavies I have this issue too. Sounds like a good addition! I don't mind sending a PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kravets-levko @Harpush