Integration testing and ICurrentUserService

[eric-oddr]

I would like to modify the integration tests such that _currentUserId is no longer static. The main reason for this is so that I can safely run the tests in parallel.

I am struggling to figure out how to set up the ICurrentUserService so that it return the "current" user (as defined in the RunAsUserAsync() method in the Testing class).

(Note, as part of this change, most of the methods in Testing would be changed from static to instance methods.)

The current logic is the following:

services
                .Remove<ICurrentUserService>()
                .AddTransient(provider => Mock.Of<ICurrentUserService>(s =>
                    s.UserId == GetCurrentUserId()));

This relies on the static method to get the User Id.

Instead, I'd like to have the service return the user ID for the current test, but I haven't been able to figure how to do this. Conceptually, it would like something like the following:

services
                .Remove<ICurrentUserService>()
                .AddTransient(provider => Mock.Of<ICurrentUserService>(s =>
                    s.UserId == myCurrentTestClass.GetCurrentUserId()));

But of course there is no such "myCurrentTestClass" when the bulding the service.

I was hoping to somehow setup the HttpContextAccessor in the test such that the following would just work from the CurrentUserService:

public string? UserId => _httpContextAccessor.HttpContext?.User?.FindFirstValue(ClaimTypes.NameIdentifier);

but I am not sure if that is possible and or recommended.

Any suggestions would be appreciated.

Thanks,
Eric

[eric-oddr]

I decided to solve this by the following:

• Create an implememtation of ICurrentUserService which allows setting the UserId
• Changing configuration to use this implementation of ICurrentUserService
• Setting the UserId in this service whenever the UserId is changed

The implementation of ICurrentUserService:

public class TestCurrentUserService : ICurrentUserService
{
    public string? UserId { get; set; }
}

The modified configuration:

     builder.ConfigureServices((builder, services) =>
        {
            services
                .Remove<ICurrentUserService>()
                .AddScoped<ICurrentUserService, TestCurrentUserService>();
...

And code to set the User ID:

        // TODO: This is needed so that application layer is aware of the current user ID.
        // There is probably a more elegant way to do this, but this is sufficient for now.
        var userService = scope.ServiceProvider.GetRequiredService<ICurrentUserService>();
        (userService as TestCurrentUserService)!.UserId = _userId;

Thanks,
Eric