Skip to content
This repository has been archived by the owner on Mar 14, 2020. It is now read-only.

Move UI code to it's own module #46

Open
jasperges opened this issue Mar 13, 2018 · 5 comments
Open

Move UI code to it's own module #46

jasperges opened this issue Mar 13, 2018 · 5 comments

Comments

@jasperges
Copy link
Owner

No description provided.

jasperges referenced this issue in sybrenstuvel/pose_thumbnails Mar 13, 2018
This prevents us from having a module `pose_thumbnails.pose_thumbnails`,
and avoids stutter.

It also makes it unambiguous what should happen if we were to write
`import pose_thumbnails` from within the `pose_thumbnails` module.
@sybrenstuvel
Copy link
Contributor

I think it's a nice idea, but IMO not necessary for a 1.0 release.

@TheDuckCow
Copy link
Contributor

@jasperges on that topic, is 1.0 essentially already ready? At the very least it would be helpful for me to have the v1.0.0 tag/release added to the repo if it's at that state.

@jasperges
Copy link
Owner Author

@TheDuckCow Sorry for the late reply, I was on holiday with the family. I will try to make some time to do a 'proper' release. I think everything is fine at the moment, but let me double check. It would be nice to have some documentation, but that will have to be done later.

@TheDuckCow
Copy link
Contributor

On the documentation front, I just made a sanitized copy of an internal usage guide I put together for my studio. Some of the wording enforces studio-specific things like naming and where files should/shoulnd' t be, these could be generalized, but regardless maybe this is something you can copy from to quickly make some simple documentation. Feel free to rip and entirely use for your own.

https://docs.google.com/document/d/1H0HO0jcon1a6SPQQ52eoVs0RAmrTDq877XhW1Mxqjgw/edit?usp=sharing

@jasperges
Copy link
Owner Author

Thank you! I had a quick look and I can certainly use this. Then finally some (basic) documentation will be available. A good target for the (long overdue) 1.0 release. 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants