Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git 2.23.2 has new security that breaks this action #4

Open
jasonamyers opened this issue Apr 13, 2022 · 6 comments
Open

Git 2.23.2 has new security that breaks this action #4

jasonamyers opened this issue Apr 13, 2022 · 6 comments

Comments

@jasonamyers
Copy link

Recently, we started getting errors like:

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

when using this action. This started when the container started install git 2.23.2-r0 instead of git 2.23.1-r0

This results in the workspace being marked as insecure due to a CVE Fix: https://github.com/git/git/blob/master/Documentation/RelNotes/2.34.2.txt

in this case, we're not in a multiuser git workspace, so we should be save to enable the git config above.

@doc-balto
Copy link

I naively tried to set git config --global --add safe.directory /github/workspace in the step beforehand, but had no luck.

@peterdudfield
Copy link

@jasonamyers
Copy link
Author

I ended up shipping https://github.com/marketplace/actions/bumpversion-action-for-github as a workaround for this issue with my PR to this repo.

@peterdudfield
Copy link

I ended up shipping https://github.com/marketplace/actions/bumpversion-action-for-github as a workaround for this issue with my PR to this repo.

@thanks @jasonamyers for this - this worked for me

@peterdudfield
Copy link

peterdudfield commented Apr 19, 2022

I ended up shipping https://github.com/marketplace/actions/bumpversion-action-for-github as a workaround for this issue with my PR to this repo.

@jasonamyers is there a slight bug / update of read me needed.

Looks like the output is 'new_ver' not 'new_tag'
your github action
readme

but maybe ive got myself confused

@jasonamyers
Copy link
Author

Good catch @peterdudfield fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants