Skip to content

solution #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 63 additions & 10 deletions src/main/java/com/epam/izh/rd/online/service/SimpleMathService.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ public class SimpleMathService implements MathService {
*/
@Override
public int compare(int value1, int value2) {
return -2;
if (value1 == value2) return 0;
else if (value1 < value2) return -1;
else return 1;
}

/**
Expand All @@ -22,7 +24,7 @@ public int compare(int value1, int value2) {
*/
@Override
public int maxFrom(int value1, int value2) {
return -1;
return Math.max(value1, value2);
}

/**
Expand All @@ -31,7 +33,11 @@ public int maxFrom(int value1, int value2) {
*/
@Override
public int maxFrom(int[] values) {
return -1;
int max = values[0];
for (int i = 1; i < values.length; i++) {
if (max < values[i]) max = values[i];
}
return max;
}

/**
Expand All @@ -40,7 +46,11 @@ public int maxFrom(int[] values) {
*/
@Override
public int sum(int[] values) {
return -1;
int sum = 0;
for (int value : values) {
sum += value;
}
return sum;
}

/**
Expand All @@ -49,7 +59,19 @@ public int sum(int[] values) {
*/
@Override
public int[] getEvenDigits(int[] values) {
return new int[]{};
int size = 0, l = 0;

for (int value : values) {
if (value % 2 == 0) size++;
}

int[] evenDigits = new int[size];

for (int value : values) {
if (value % 2 == 0) evenDigits[l++] = value;
}

return evenDigits;
}

/**
Expand All @@ -59,7 +81,12 @@ public int[] getEvenDigits(int[] values) {
*/
@Override
public long calcFactorial(int initialVal) {
return -1L;
int fact = 1;
if (initialVal == 0) return 1;
for(int i = 2; i <= initialVal; i++) {
fact *= i;
}
return fact;
}

/**
Expand All @@ -70,11 +97,20 @@ public long calcFactorial(int initialVal) {
* Пример 0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55 ...
*
* Для числа 9 метод должен вернуть 34
* Для числа 4 метод должен вернуть 3
* Для числа 0 метод должен вернуть 0
*/
@Override
public long calcFibonacci(int number) {
return -1L;
if (number == 0) return 0;
if (number == 1) return 1;

int fib1 = 0, fib2 = 1;
for (int i = 0; i < number / 2; i++) {
fib1 = fib1 + fib2;
fib2 = fib1 + fib2;
}
return number % 2 == 0 ? fib1 : fib2;
}

/**
Expand All @@ -83,7 +119,16 @@ public long calcFibonacci(int number) {
*/
@Override
public int[] sort(int[] values) {
return new int[]{};
for (int i = 0; i < values.length; i++) {
for (int k = 0; k < values.length - 1; k++) {
if (values[i] < values[k]) {
int temp = values[i];
values[i] = values[k];
values[k] = temp;
}
}
}
return values;
}

/**
Expand All @@ -94,7 +139,10 @@ public int[] sort(int[] values) {
*/
@Override
public boolean isPrimary(int number) {
return false;
for (int i = 2; i < number; i++) {
if (number % i == 0) return false;
}
return true;
}

/**
Expand All @@ -104,6 +152,11 @@ public boolean isPrimary(int number) {
*/
@Override
public int[] reverseArray(int[] values) {
return new int[]{};
for (int i = 0; i < values.length / 2; i++) {
int temp = values[i];
values[i] = values[values.length - i - 1];
values[values.length - i - 1] = temp;
}
return values;
}
}