Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parseInt when reading PC definitions #299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Trantion897
Copy link

@Trantion897 Trantion897 commented Aug 16, 2024

Pull Request Description

Avoids failures caused by the user defining frontmatter as a string instead of a number, such as trying to concatenate numbers as strings instead of adding

Changes Proposed

  • NewPlayerModal calls parseInt() on all player values except name

Related Issues

Fixes #291

Checklist

  • I have read the contribution guidelines and code of conduct.
  • I have tested the changes locally and they are working as expected.
  • I have added appropriate comments and documentation for the code changes.
  • My code follows the coding style and standards of this project.
  • I have rebased my branch on the latest main (or master) branch.
  • All tests (if applicable) have passed successfully.
  • I have run linters and fixed any issues.
  • I have checked for any potential security issues or vulnerabilities.

Screenshots (if applicable)

Additional Notes

Avoids failures caused by the user defining frontmatter as a string instead of a number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Encounter XP is 0 with more than one player in pf2e & dnd5e
1 participant