diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/AbstractUpgradeCompatibilityTestCase.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/AbstractUpgradeCompatibilityTestCase.java index 4ff2b80aa29cc..83473e7b990d4 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/AbstractUpgradeCompatibilityTestCase.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/AbstractUpgradeCompatibilityTestCase.java @@ -73,9 +73,11 @@ public abstract class AbstractUpgradeCompatibilityTestCase extends ESRestTestCas private static boolean upgradeFailed = false; private final Version clusterVersion; + private final String indexCreatedVersion; - public AbstractUpgradeCompatibilityTestCase(@Name("cluster") Version clusterVersion) { + public AbstractUpgradeCompatibilityTestCase(@Name("cluster") Version clusterVersion, String indexCreatedVersion) { this.clusterVersion = clusterVersion; + this.indexCreatedVersion = indexCreatedVersion; } @ParametersFactory @@ -208,4 +210,8 @@ private static void unzip(Path zipFilePath, Path outputDir) throws IOException { } } } + + public final void testArchiveIndex() throws Exception { + verifyCompatibility(indexCreatedVersion); + } } diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/ArchiveIndexTestCase.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/ArchiveIndexTestCase.java index 17bdb76e0eae5..fb6f0c4140b62 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/ArchiveIndexTestCase.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/ArchiveIndexTestCase.java @@ -25,14 +25,14 @@ * when deployed ES version 5/6. The cluster then upgrades to version 9, verifying that the archive index * is successfully restored. */ -public class ArchiveIndexTestCase extends AbstractUpgradeCompatibilityTestCase { +abstract class ArchiveIndexTestCase extends AbstractUpgradeCompatibilityTestCase { static { clusterConfig = config -> config.setting("xpack.license.self_generated.type", "trial"); } - public ArchiveIndexTestCase(Version version) { - super(version); + protected ArchiveIndexTestCase(Version version, String indexCreatedVersion) { + super(version, indexCreatedVersion); } /** diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion5IT.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion5IT.java index 9f62d65592a37..8606d1a467a29 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion5IT.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion5IT.java @@ -12,10 +12,6 @@ public class RestoreFromVersion5IT extends ArchiveIndexTestCase { public RestoreFromVersion5IT(Version version) { - super(version); - } - - public void testArchiveIndex() throws Exception { - verifyCompatibility("5"); + super(version, "5"); } } diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion6IT.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion6IT.java index b3cca45c205f6..ae75630f9e636 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion6IT.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/archiveindex/RestoreFromVersion6IT.java @@ -12,10 +12,6 @@ public class RestoreFromVersion6IT extends ArchiveIndexTestCase { public RestoreFromVersion6IT(Version version) { - super(version); - } - - public void testArchiveIndex() throws Exception { - verifyCompatibility("6"); + super(version, "6"); } } diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion5IT.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion5IT.java index 3e371b5128b6a..49ac218bfd646 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion5IT.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion5IT.java @@ -12,10 +12,6 @@ public class MountFromVersion5IT extends SearchableSnapshotTestCase { public MountFromVersion5IT(Version version) { - super(version); - } - - public void testSearchableSnapshot() throws Exception { - verifyCompatibility("5"); + super(version, "5"); } } diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion6IT.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion6IT.java index 29b81fe595e5f..10b73b42df6b3 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion6IT.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/MountFromVersion6IT.java @@ -12,10 +12,6 @@ public class MountFromVersion6IT extends SearchableSnapshotTestCase { public MountFromVersion6IT(Version version) { - super(version); - } - - public void testSearchableSnapshot() throws Exception { - verifyCompatibility("6"); + super(version, "6"); } } diff --git a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/SearchableSnapshotTestCase.java b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/SearchableSnapshotTestCase.java index 08a5db2111904..ddc5c4a70f891 100644 --- a/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/SearchableSnapshotTestCase.java +++ b/x-pack/qa/repository-old-versions-compatibility/src/javaRestTest/java/org/elasticsearch/oldrepos/searchablesnapshot/SearchableSnapshotTestCase.java @@ -21,14 +21,14 @@ * Restores snapshots from old-clusters (version 5/6) and upgrades it to the current version. * Test methods are executed after each upgrade. */ -public class SearchableSnapshotTestCase extends AbstractUpgradeCompatibilityTestCase { +abstract class SearchableSnapshotTestCase extends AbstractUpgradeCompatibilityTestCase { static { clusterConfig = config -> config.setting("xpack.license.self_generated.type", "trial"); } - public SearchableSnapshotTestCase(Version version) { - super(version); + protected SearchableSnapshotTestCase(Version version, String indexCreatedVersion) { + super(version, indexCreatedVersion); } /** diff --git a/x-pack/qa/repository-old-versions/src/test/java/org/elasticsearch/oldrepos/DocValueOnlyFieldsIT.java b/x-pack/qa/repository-old-versions/src/test/java/org/elasticsearch/oldrepos/DocValueOnlyFieldsIT.java index 968262448c87e..8cf58f0c2c082 100644 --- a/x-pack/qa/repository-old-versions/src/test/java/org/elasticsearch/oldrepos/DocValueOnlyFieldsIT.java +++ b/x-pack/qa/repository-old-versions/src/test/java/org/elasticsearch/oldrepos/DocValueOnlyFieldsIT.java @@ -30,7 +30,7 @@ import java.io.IOException; /** - * Tests doc-value-based searches against indices imported from clusters older than N-1. + * Tests doc-value-based searches against archive indices, imported from clusters older than N-2. * We reuse the YAML tests in search/390_doc_values_search.yml but have to do the setup * manually here as the setup is done on the old cluster for which we have to use the * low-level REST client instead of the YAML set up that only knows how to talk to