Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving information presented in functions #25

Open
RSKothari opened this issue Apr 28, 2020 · 1 comment
Open

Improving information presented in functions #25

RSKothari opened this issue Apr 28, 2020 · 1 comment

Comments

@RSKothari
Copy link

RSKothari commented Apr 28, 2020

Hi,

Great work. Might be including in future papers of mine. Found one issue:
https://github.com/javiribera/locating-objects-without-bboxes/blob/master/object-locator/losses.py

Might help if you explicitly mentioned that in the case for 1 GT point, be sure to provide it as list of a [1, 2] tensors. This shape is consistent with your code and would lead to failure if people provided GT points as [2, ] or [2, 1].

Further, I suggest removed "device" dependency during function definition and instead consider something like this self.all_img_locations = self.all_img_locations.to(prob_map.device)

Would help future users who train on cluster.

@javiribera
Copy link
Owner

Yes, both suggestions would make it more convenient for the novice user. Would you do a pull request? That'd be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants