We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The maximum possible distance is calculated with resized image size.
locating-objects-without-bboxes/object-locator/losses.py
Line 143 in e51f75e
But this should be calculated with the original image size, as bellow code also calculates distances in the original image.
Bellow two lines need to be changed
Line 224 in e51f75e
Line 204 in e51f75e
Suggested change
max_dist = (orig_size_b **2).sum().sqrt() .... # Corner case: no GT points if gt_b.ndimension() == 1 and (gt_b < 0).all().item() == 0: terms_1.append(torch.tensor([0], dtype=torch.get_default_dtype())) terms_2.append(torch.tensor([max_dist], dtype=torch.get_default_dtype())) continue ..... weighted_d_matrix = (1 - p_replicated)*max_dist + p_replicated*d_matrix
I am sorry, too lazy to make pull request to fix it by myself now.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The maximum possible distance is calculated with resized image size.
locating-objects-without-bboxes/object-locator/losses.py
Line 143 in e51f75e
But this should be calculated with the original image size, as bellow code also calculates distances in the original image.
Bellow two lines need to be changed
locating-objects-without-bboxes/object-locator/losses.py
Line 224 in e51f75e
locating-objects-without-bboxes/object-locator/losses.py
Line 204 in e51f75e
Suggested change
I am sorry, too lazy to make pull request to fix it by myself now.
The text was updated successfully, but these errors were encountered: