Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CSS after "... to add 76px /": expected 1 selector or at-rule, was "_::full-page-media," #149

Open
Romchik opened this issue Apr 25, 2017 · 3 comments

Comments

@Romchik
Copy link

Romchik commented Apr 25, 2017

// app.css

@import "node_modules/vegas/src/sass/vegas";

// webpack.mix.js

mix
    .scripts(
        [
            'node_modules/jquery/dist/jquery.js',
            'node_modules/bootstrap-sass/assets/javascripts/bootstrap.js',
            'node_modules/vegas/dist/vegas.js',
            'resources/assets/js/main.js',
        ],
        'public/js/all.js'
    )
    .sass('resources/assets/sass/app.scss', 'public/css')
    .version();

Wenn I run 'npm production' (webpack command from Laravel 5.4):

Module build failed:
/* Target Safari IOS7+ in order to add 76px */
Invalid CSS after "... to add 76px */": expected 1 selector or at-rule, was "_::full-page-media,"
in /node_modules/vegas/src/sass/main/vegas.sass (line 63, column 47)

It's possible to fix it?

@sebastiansulinski
Copy link

The problem is with the node_modules/vegas/src/sass/main/vegas.scss, which uses iOS Safari hack - I'm not sure it is still needed, but the get rid of the problem you can remove the following form the end of this file:

/* Target Safari IOS7+ in order to add 76px */
_::full-page-media, _:future,
:root body.vegas-container > .vegas-slide,
:root body.vegas-container > .vegas-overlay
    bottom: -76px

@fwermelinger
Copy link

This hack also affects Asp.net MVC. When adding the CSS with the Frameworks CSS bundler it will throw an "index out of range" exception because it doesn't know the _: selector.

Microsoft.Ajax.Utilities.CssParser has a problem with _: css selector.

https://stackoverflow.com/a/26696078/1838774

EmperorArthur added a commit to EmperorArthur/vegas that referenced this issue Jun 17, 2018
This was preventing laravel mix (webpack) and Asp.net MVC from compiling the sass.
@EmperorArthur
Copy link

I can confirm this is still an issue, and have opened a pull request to remove the offending code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants