Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More attributes to extra_context #701

Open
matheusml opened this issue Oct 8, 2019 · 1 comment
Open

More attributes to extra_context #701

matheusml opened this issue Oct 8, 2019 · 1 comment

Comments

@matheusml
Copy link

matheusml commented Oct 8, 2019

Hey, thanks for the awesome work ❤️

I've been trying to optimize the CSS part of the bundle, by following Google's advice to Defer CSS: https://developers.google.com/web/tools/lighthouse/audits/blocking-resources

To do that, I'll have to add a disabled attribute to <link /> tags, but it seems like django pipeline currently only support the media attribute for extra_context: https://django-pipeline.readthedocs.io/en/latest/configuration.html#extra-context

If I create the PR with that, would you accept?

@matheusml matheusml changed the title More attributes to extra_context More attributes to extra_context Oct 8, 2019
@Pyvonix
Copy link

Pyvonix commented Jul 2, 2020

Hi @matheusml, all PR are welcome. As the creator explains it:

Since this project is part of Jazzband, y’all are empowered to contribute and maintain django-pipeline.

If the functionality is relevant and all the tests pass, there is no reason why it is not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants