Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are requesting help to disable branch protection rules for django-fsm-log #368

Open
ticosax opened this issue Jun 24, 2024 · 5 comments
Labels

Comments

@ticosax
Copy link
Member

ticosax commented Jun 24, 2024

Hi,
Over time, the branch protection rules, that expect some checks related to python versions, might become obsolete. Like observed in this pull request.
jazzband/django-fsm-log#192

I'm suggesting to disable the branch protection rules, if only the roadies can keep them up to date. Unless the maintainers can control them, in that case it should probably become a maintainer responsibility, in order to remove dependency on the roadies for such ongoing tasks.

Thanks.

@ticosax ticosax changed the title We are requesting to disable branch protection rules for django-fsm-log We are requesting help to disable branch protection rules for django-fsm-log Nov 27, 2024
@ticosax
Copy link
Member Author

ticosax commented Nov 27, 2024

@jezdez Sorry to mention you. I don't see an alternative that doesn't involve your direct support. Or maybe, someone else has access to the branch protection rules settings ?

@jezdez
Copy link
Member

jezdez commented Dec 9, 2024

Sorry for the long delay. I've just removed Python 3.7 from the required CI checks. The best solution without removing branch protection outright is to use someting like https://github.com/re-actors/alls-green. Removing branch protection completely isn't a good idea, sadly (due to malicious actors in Jazzband).

You should be able to roll out something like alls-green now with the maintainer permissions to the repo I just gave the project leads. Can you verify this?

@ticosax
Copy link
Member Author

ticosax commented Dec 10, 2024

Thanks a lot @jezdez, I didn't know about this project. I will definitely try to take advantage of it. I'll get my hands on it in the following days.

@webknjaz
Copy link
Member

@ticosax feel free to tag me if you face challenges integrating it!

@ticosax
Copy link
Member Author

ticosax commented Dec 17, 2024

@jezdez, thanks again. I made a PR with the alls-green integration.
I'll wait for other maintainers to chime in, but it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants