Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support Django 3.1, 3.2, 4.0 and Python 3.9, 3.10 on PyPI #683

Closed
uri-rodberg opened this issue Dec 26, 2021 · 6 comments
Closed

Comments

@uri-rodberg
Copy link
Contributor

PyPi only lists support of sorl-thumbnail to Django <= 3.0 and Python <= 3.8. I would like to see sorl-thumbnail officially supporting newer versions - Django 3.1, 3.2, 4.0 and Python 3.9, 3.10. And also, development status on PyPI is 2 - Pre-Alpha - can you increase it to 5 - Production/Stable maybe?

From my testing, sorl-thumbnail==12.7.0 works with Django 3.1, 3.2, 4.0, and Python 3.9, 3.10.

@jayvdb
Copy link
Member

jayvdb commented Jan 6, 2022

The majority of this was done in #682 , however PyPI metadata and docs still need an update.

See also #675

@claudep
Copy link
Contributor

claudep commented Feb 5, 2022

This is done in master branch, so #675 is indeed the ticket to track now.

@claudep claudep closed this as completed Feb 5, 2022
@uri-rodberg
Copy link
Contributor Author

Django 4.0 and Python 3.9, 3.10 not supported on PyPI (sorl-thumbnail 12.8.0), although they are mentioned on https://github.com/jazzband/sorl-thumbnail/blob/master/CHANGES.rst.

@claudep
Copy link
Contributor

claudep commented Feb 11, 2022

Indeed, updating setup.py was forgotten, are you willing to make the corrective patch?

@uri-rodberg
Copy link
Contributor Author

Indeed, updating setup.py was forgotten, are you willing to make the corrective patch?

I can try. But you will need to release again. I'm not sure if that's possible with the same release version.

Do we still want to keep 'Development Status :: 2 - Pre-Alpha'?

@claudep
Copy link
Contributor

claudep commented Feb 11, 2022

From the time the package exists, it should be noted as Stable IMHO. There is now a PR: #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants