Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping the Microsoft.Data.SqlClient dependency #152

Open
0xced opened this issue Nov 27, 2024 · 1 comment · May be fixed by #153
Open

Consider dropping the Microsoft.Data.SqlClient dependency #152

0xced opened this issue Nov 27, 2024 · 1 comment · May be fixed by #153

Comments

@0xced
Copy link

0xced commented Nov 27, 2024

It's here only to support the CreateAsync and ResetAsync overloads that take a connection string instead of a connection.

It's a real shame to take a dependency on Microsoft.Data.SqlClient if you only ever plan to use this on PostgreSQL or MySQL for example.

It's also less of a maintenance burden (see also #142) to not have that dependency.

Of course that would require a major release since it's a breaking change.

Finally, it would be very smooth along with #151.

0xced added a commit to 0xced/Respawn that referenced this issue Feb 5, 2025
Breaking change that requires bumping the major version of this library.

Fixes jbogard#152
@0xced 0xced linked a pull request Feb 5, 2025 that will close this issue
@drusellers
Copy link

I noticed that I'm getting build warnings about Azure.Identity and that warning comes from Respawn and its dependency on this lib. Not sure what the correct approach is but would be nice to get this out of my logs. :)

15>MessageAid.Tests.csproj: Warning NU1903 : Package 'Azure.Identity' 1.3.0 has a known high severity vulnerability, https://github.com/advisories/GHSA-5mfx-4wcx-rv27
15>MessageAid.Tests.csproj: Warning NU1902 : Package 'Azure.Identity' 1.3.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-m5vv-6r4h-3vj9
15>MessageAid.Tests.csproj: Warning NU1902 : Package 'Azure.Identity' 1.3.0 has a known moderate severity vulnerability, https://github.com/advisories/GHSA-wvxc-855f-jvrv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants