Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit isolation of Bearer token #35

Open
jcorry opened this issue Apr 7, 2019 · 0 comments
Open

Revisit isolation of Bearer token #35

jcorry opened this issue Apr 7, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jcorry
Copy link
Owner

jcorry commented Apr 7, 2019

This seems error prone. Can you check the type of Authorization header as well? I know it will throw an unauthorized error if the length is not as expected which could be enough but just food for thought.

Maybe something like:

if len(bearerToken) == 2 && strings.Contains(bearerToken[0], "Bearer") {

Originally posted by @syntacticNaCl in #33

@jcorry jcorry added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant