Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

company-keywords backend is not working after recent update #14

Closed
CsBigDataHub opened this issue Nov 19, 2020 · 5 comments
Closed

company-keywords backend is not working after recent update #14

CsBigDataHub opened this issue Nov 19, 2020 · 5 comments
Labels
question Further information is requested

Comments

@CsBigDataHub
Copy link

company-keywords backend is not working after the update.

company-keywords doesn't show up at all.

current package-version - company-fuzzy-20201020-1552

emacs-version - 27.1

company-version - 0.9.13 - package-version = company-20201004.735

Update :

Can confirm that it is working until this commit - 2f70e6f
I have tested it using quelpa.

(use-package company-fuzzy
  :quelpa
  (company-fuzzy
   :fetcher github
   :repo "jcs-elpa/company-fuzzy"
   :commit "2f70e6fe78c45d0cbbb22b1d994f90aa9c78553b"
   )
  :init
  (setq company-fuzzy-sorting-backend 'flx)
  (setq company-fuzzy-prefix-ontop nil)
  (with-eval-after-load 'company
    (global-company-fuzzy-mode t)))

I just tested it with jenkinsfile-mode
https://github.com/john2x/jenkinsfile-mode/blob/65bf3925852c35c6bd499978f08f83c1193f4347/jenkinsfile-mode.el#L299

@jcs090218
Copy link
Member

I have tested with jenkinsfile-mode and it works in the latest version. 😕

I realized that you add keywords to company-keywords-alist weather company is found. Did company activate in the before jenkinsfile-mode is loaded? (Just want to make sure) Otherwise, I am not able to reproduce this issue. 😕 Thanks!

@jcs090218 jcs090218 added the question Further information is requested label Nov 20, 2020
@CsBigDataHub
Copy link
Author

CsBigDataHub commented Nov 20, 2020

@jcs090218 Thanks for replying.
Yes company is activated globally at init. I have posted my config here #12 (comment).

I have company-backends configured like this -

 company-backends '((company-capf :with company-yasnippet)
                           (company-dabbrev-code company-keywords company-files)
                           company-dabbrev))

Do you think this order of backends will help?

(setq company-backends
        (append
         ;; --- Internal ---
         '(company-capf company-semantic)
         '(company-keywords)    ; Put infront of `company-dabbrev'
         '(company-abbrev company-dabbrev company-dabbrev-code)
         '(company-files)
         '(company-etags company-gtags)
         '(company-yasnippet)
         ;; --- External ---
         '(company-emoji)))

@jcs090218
Copy link
Member

jcs090218 commented Nov 20, 2020

Do you think this order of backends will help?

Yes, In my case dabbrev take over some of the keywords backend because both of them have the same candidates. This is related to #6.

Yet jenkinsfile-mode's has a very unique keywords like ViolationsToGitHub. I assumed it has no way to be in dabbrev backend, then in this case it wouldn't matter. The order is only matters to the annotation. If the candidates like ViolationsToGitHub isn't appearing then it is a bug! 😖 But I am not able to reproduce for now! 😕

ezgif-1-cb137ae64183

@CsBigDataHub
Copy link
Author

Let me try that out. Will keep you posted.

@CsBigDataHub
Copy link
Author

@jcs090218 Thanks for your help. Changing the order did help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants