Skip to content

Commit 9227dc6

Browse files
committed
bug fix for tweener and naming issue
1 parent a56bbf7 commit 9227dc6

File tree

12 files changed

+102
-47
lines changed

12 files changed

+102
-47
lines changed

Assets/FrameworkTest_Assets/Scripts/FT_ParticleSytem_Test.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ private void Update()
5252
{
5353
if (JCS_Input.GetKeyDown(KeyCode.G))
5454
{
55-
JCS_TransfromTweener masterTweener = mParticle.GetComponent<JCS_TransfromTweener>();
55+
JCS_TransformTweener masterTweener = mParticle.GetComponent<JCS_TransformTweener>();
5656
JCS_TowardTarget masterTt = mParticle.GetComponent<JCS_TowardTarget>();
5757

5858
for (int index = 0;
5959
index < mParticles.length;
6060
++index)
6161
{
62-
JCS_TransfromTweener tweener = mParticles.at(index).GetComponent<JCS_TransfromTweener>();
62+
JCS_TransformTweener tweener = mParticles.at(index).GetComponent<JCS_TransformTweener>();
6363

6464
tweener.EasingX = masterTweener.EasingX;
6565
tweener.EasingY = masterTweener.EasingY;

Assets/JCSUnity/Scripts/Effects/2D/JCS_2DConstWaveEffect.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class JCS_2DConstWaveEffect
2727
/* Private Variables */
2828
/*******************************************/
2929

30-
[Header("** Initialize Varialbes (JCS_2DConstWaveEffect) **")]
30+
[Header("** Runtime Varialbes (JCS_2DConstWaveEffect) **")]
3131

3232
[Tooltip("as play on awake!")]
3333
[SerializeField]

Assets/JCSUnity/Scripts/Effects/Item/JCS_Item.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ other sound. (Effect Sound)")]
9696

9797
[Header("** Optional Variables (JCS_UnityObject) **")]
9898
[SerializeField]
99-
private JCS_TransfromTweener mTweener = null;
99+
private JCS_TransformTweener mTweener = null;
100100
[SerializeField]
101101
private JCS_DestinationDestroy mDestinationDestroy = null;
102102

@@ -129,7 +129,7 @@ protected override void Awake()
129129
protected virtual void Start()
130130
{
131131
if (mTweener == null)
132-
mTweener = this.GetComponent<JCS_TransfromTweener>();
132+
mTweener = this.GetComponent<JCS_TransformTweener>();
133133
if (mDestinationDestroy == null)
134134
mDestinationDestroy = this.GetComponent<JCS_DestinationDestroy>();
135135
}
@@ -276,7 +276,7 @@ private void DropEffect(Collider other)
276276
if (mTweener == null)
277277
{
278278
// default settings
279-
mTweener = this.gameObject.AddComponent<JCS_TransfromTweener>();
279+
mTweener = this.gameObject.AddComponent<JCS_TransformTweener>();
280280

281281
mTweener.EasingY = JCS_TweenType.EASE_OUT_BACK;
282282
mTweener.DurationX = 2.0f;

Assets/JCSUnity/Scripts/Effects/JCS_SlideEffect.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace JCSUnity
1515

1616
/// <summary>
1717
/// Make object to make the smooth slide effect.
18-
/// - Could be compose with JCS_TransfromTweener class.
18+
/// - Could be compose with JCS_TransformTweener class.
1919
/// </summary>
2020
public class JCS_SlideEffect
2121
: JCS_UnityObject

Assets/JCSUnity/Scripts/Effects/Particle/Type/JCS_TowardTarget.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace JCSUnity
1616
/// <summary>
1717
/// Particle will lerp to the target position.
1818
/// </summary>
19-
[RequireComponent(typeof(JCS_TransfromTweener))]
19+
[RequireComponent(typeof(JCS_TransformTweener))]
2020
[RequireComponent(typeof(JCS_DisableWithCertainRangeEvent))]
2121
public class JCS_TowardTarget
2222
: JCS_Particle
@@ -29,7 +29,7 @@ public class JCS_TowardTarget
2929
// Private Variables
3030

3131
// tweener effect to the object.
32-
private JCS_TransfromTweener mJCSTweener = null;
32+
private JCS_TransformTweener mJCSTweener = null;
3333

3434
// when reach the certain range disable it.
3535
private JCS_DisableWithCertainRangeEvent mDisableWidthCertainRangeEvent = null;
@@ -78,7 +78,7 @@ public void SetTargetTransfrom(Transform trans)
7878
//------------------------------
7979
private void Awake()
8080
{
81-
this.mJCSTweener = this.GetComponent<JCS_TransfromTweener>();
81+
this.mJCSTweener = this.GetComponent<JCS_TransformTweener>();
8282
this.mDisableWidthCertainRangeEvent = this.GetComponent<JCS_DisableWithCertainRangeEvent>();
8383

8484
// set destination callback.

Assets/JCSUnity/Scripts/Effects/Tweener/JCS_TransfromTweener.cs renamed to Assets/JCSUnity/Scripts/Effects/Tweener/JCS_TransformTweener.cs

Lines changed: 48 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* $File: JCS_TransfromTweener.cs $
2+
* $File: JCS_TransformTweener.cs $
33
* $Date: $
44
* $Revision: $
55
* $Creator: Jen-Chieh Shen $
@@ -13,11 +13,10 @@
1313

1414
namespace JCSUnity
1515
{
16-
1716
/// <summary>
1817
/// Tweener Effect
1918
/// </summary>
20-
public class JCS_TransfromTweener
19+
public class JCS_TransformTweener
2120
: JCS_UnityObject
2221
{
2322

@@ -27,7 +26,7 @@ public class JCS_TransfromTweener
2726
//----------------------
2827
// Private Variables
2928

30-
[Header("** Check Variables (JCS_TransfromTweener) **")]
29+
[Header("** Check Variables (JCS_TransformTweener) **")]
3130

3231
[SerializeField]
3332
private bool mContinueTween = false;
@@ -40,28 +39,31 @@ public class JCS_TransfromTweener
4039
private Vector3 mRecordTargetTransformPosition = Vector3.zero;
4140

4241
private Transform mRecordTransform = null;
43-
42+
4443
[Tooltip("Is done tweening/animating?")]
4544
[SerializeField]
4645
private bool mIsDoneTweening = false;
4746

4847

49-
[Header("** Runtime Variables (JCS_TransfromTweener) **")]
48+
[Header("** Runtime Variables (JCS_TransformTweener) **")]
5049

5150
[Tooltip("Do the tween effect?")]
5251
[SerializeField]
5352
private bool mTween = true;
5453

5554
[Tooltip("How fase it move on x axis.")]
56-
[SerializeField] [Range(0.01f, 1000.0f)]
55+
[SerializeField]
56+
[Range(0.01f, 1000.0f)]
5757
private float mDurationX = 1.0f;
5858

5959
[Tooltip("How fase it move on y axis.")]
60-
[SerializeField] [Range(0.01f, 1000.0f)]
60+
[SerializeField]
61+
[Range(0.01f, 1000.0f)]
6162
private float mDurationY = 1.0f;
6263

6364
[Tooltip("How fase it move on z axis.")]
64-
[SerializeField] [Range(0.01f, 1000.0f)]
65+
[SerializeField]
66+
[Range(0.01f, 1000.0f)]
6567
private float mDurationZ = 1.0f;
6668

6769
[Tooltip("Enable this if the target is moving all the time.")]
@@ -76,30 +78,24 @@ [SerializeField] [Range(0.01f, 1000.0f)]
7678
private bool mDestroyWhenDoneTweening = false;
7779

7880
[Tooltip("How many times of done tweening destroy will active?")]
79-
[SerializeField] [Range(1, 10)]
81+
[SerializeField]
82+
[Range(1, 10)]
8083
private int mDestroyDoneTweeningCount = 1;
8184

8285

8386
[Header("- Randomize Duration")]
8487

8588
[Tooltip("Randomize the duration with all axis at start. (x, y, z)")]
86-
[SerializeField] [Range(0.0f, 1000.0f)]
89+
[SerializeField]
90+
[Range(0.0f, 1000.0f)]
8791
private float mRandomizeDuration = 0.0f;
8892

8993

9094
[Header("- Tweener Effect Transform")]
9195

92-
[Tooltip("Do tween effect with position?")]
93-
[SerializeField]
94-
private bool mTweenPosition = true;
95-
96-
[Tooltip("Do tween effect with rotation?")]
96+
[Tooltip("Which transform's properties to tween.")]
9797
[SerializeField]
98-
private bool mTweenRotation = false;
99-
100-
[Tooltip("Do tween effect with scale?")]
101-
[SerializeField]
102-
private bool mTweenScale = false;
98+
private JCS_TransformType mTweenType = JCS_TransformType.POSITION;
10399

104100
[Tooltip("Do the track base on location position.")]
105101
[SerializeField]
@@ -123,7 +119,7 @@ [SerializeField] [Range(0.0f, 1000.0f)]
123119
private Vector3Tweener tweener = new Vector3Tweener();
124120

125121

126-
[Header("- Continuous Tween (JCS_TransfromTweener) ")]
122+
[Header("- Continuous Tween (JCS_TransformTweener) ")]
127123

128124
[Tooltip("While Continue tween when did the tweener algorithm stop?")]
129125
[SerializeField]
@@ -151,7 +147,8 @@ [SerializeField] [Range(0.0f, 1000.0f)]
151147
public Transform RecordTransform { get { return this.mRecordTransform; } }
152148
public bool DestroyWhenDoneTweening { get { return this.mDestroyWhenDoneTweening; } set { this.mDestroyWhenDoneTweening = value; } }
153149
public bool TweenEveryFrame { get { return this.mTweenEveryFrame; } set { this.mTweenEveryFrame = value; } }
154-
150+
public JCS_TransformType TweenType { get { return this.mTweenType; } set { this.mTweenType = value; } }
151+
155152
//========================================
156153
// Unity's function
157154
//------------------------------
@@ -185,12 +182,18 @@ private void LateUpdate()
185182
tweener.updateZ();
186183

187184
// Set the Position
188-
if (mTweenPosition)
189-
transform.localPosition = tweener.progression;
190-
if (mTweenRotation)
191-
transform.localEulerAngles = tweener.progression;
192-
if (mTweenScale)
193-
transform.localScale = tweener.progression;
185+
switch (mTweenType)
186+
{
187+
case JCS_TransformType.POSITION:
188+
transform.localPosition = tweener.progression;
189+
break;
190+
case JCS_TransformType.ROTATION:
191+
transform.localEulerAngles = tweener.progression;
192+
break;
193+
case JCS_TransformType.SCALE:
194+
transform.localScale = tweener.progression;
195+
break;
196+
}
194197

195198
mIsDoneTweening = false;
196199
}
@@ -287,7 +290,22 @@ public void DoTween(
287290
JCS_TweenType typeZ,
288291
CallBackDelegate callback = null)
289292
{
290-
DoTween(LocalPosition, to, durationX, durationY, durationZ, typeX, typeY, typeZ, callback);
293+
Vector3 from = Vector3.zero;
294+
295+
switch (mTweenType)
296+
{
297+
case JCS_TransformType.POSITION:
298+
from = LocalPosition;
299+
break;
300+
case JCS_TransformType.ROTATION:
301+
from = LocalEulerAngles;
302+
break;
303+
case JCS_TransformType.SCALE:
304+
from = LocalScale;
305+
break;
306+
}
307+
308+
DoTween(from, to, durationX, durationY, durationZ, typeX, typeY, typeZ, callback);
291309
}
292310

293311
/// <summary>
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/**
2+
* $File: JCS_TransformType.cs $
3+
* $Date: 2017-09-10 07:06:47 $
4+
* $Revision: $
5+
* $Creator: Jen-Chieh Shen $
6+
* $Notice: See LICENSE.txt for modification and distribution information
7+
* Copyright (c) 2017 by Shen, Jen-Chieh $
8+
*/
9+
using System.Collections;
10+
using System.Collections.Generic;
11+
using UnityEngine;
12+
13+
14+
namespace JCSUnity
15+
{
16+
/// <summary>
17+
/// List of transform properties.
18+
/// </summary>
19+
public enum JCS_TransformType
20+
{
21+
POSITION,
22+
ROTATION,
23+
SCALE
24+
}
25+
}

Assets/JCSUnity/Scripts/Enums/JCS_TransformType.cs.meta

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Assets/JCSUnity/Scripts/GUI/JCS_BlackSlideScreen.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace JCSUnity
1616
/// <summary>
1717
/// Black Slide Screen
1818
/// </summary>
19-
[RequireComponent(typeof(JCS_TransfromTweener))]
19+
[RequireComponent(typeof(JCS_TransformTweener))]
2020
public class JCS_BlackSlideScreen
2121
: MonoBehaviour
2222
{
@@ -26,7 +26,7 @@ public class JCS_BlackSlideScreen
2626

2727
//----------------------
2828
// Private Variables
29-
private JCS_TransfromTweener mTweener = null;
29+
private JCS_TransformTweener mTweener = null;
3030

3131
private Vector3 mStartingPosition = Vector3.zero;
3232

@@ -42,7 +42,7 @@ public class JCS_BlackSlideScreen
4242
//------------------------------
4343
private void Awake()
4444
{
45-
this.mTweener = this.GetComponent<JCS_TransfromTweener>();
45+
this.mTweener = this.GetComponent<JCS_TransformTweener>();
4646
}
4747

4848
private void Start()

0 commit comments

Comments
 (0)