Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new functionality #179

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Add new functionality #179

wants to merge 34 commits into from

Conversation

brucelawson
Copy link

@brucelawson brucelawson commented Mar 2, 2021

  • change the name of screenreader wand, which over-promises; added exposure of value attribute on input type=submit fields (as that is what gets exposed and wasn't being reported). Add value of aria-describedby attributes as that is also passed to AT, especially as hints/ instructions on form fields
  • stop contrast checker grumbling about transparent (therefore, invisible) text, eg on Amazon, Guardian). Also don't check text 'visually hidden' using the common clip pattern
  • Add tests for empty nav, header, main, aside, footer, figcaption. These could be announced to screen reader users (but will be empty) and justifiably make people furiously grumpy.
  • When hovering over a tota11y label, max its z-index in case it is obscured by a nearby label in busy pages.
  • Make the menu responsive when screen is zoomed to 200%
  • New Titles module to show missing titles on iframes (error), and warnings for superfluous titles on other things erroneously put there to placate the false idols of Search Engine Optimists (see The Trials and Tribulations of the Title Attribute)
  • Correct calculation of contrast ratio in the contrast module to take account of boldness of text and not just rely on font-size. (Thanks Mozilla dev tools!). Added MPL license.
  • New module to highlight empty elements, eg headings
  • Tweaked img/alt module to ask users to check accuracy of alt text (rather than perhaps falsely-reassure that presence of alt text is actually useful)
  • Add links to Babylon DNA guidance where applicable
  • Split out modules into 'designers'/ content editors and Developers (was 'Experimental')
  • New module to expose HTML5 landmarks (footer, header etc) and explicitly set ARIA roles (but not those that are implicit, because that's not as useful for diagnosing coder errors)

NOTE: nothing is changed in the 'test' part of the code as I didn't use it. Or understand it, to be honest....

Bruce Lawson added 30 commits November 27, 2020 14:03
label plugin is deprecated; use aria label+descriptions plugin instead
for testing empty elements pugin
bold text wasn't accounted for in old axs test
TODO: clean up annotations
@khanbot
Copy link

khanbot commented Mar 2, 2021

CLA signature looks good 👍

@imcodingideas imcodingideas mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants