From 52cb2f6af69ad510d7e0741c164bad2e0e7094a4 Mon Sep 17 00:00:00 2001 From: John Davis Date: Tue, 19 Mar 2024 22:44:02 -0400 Subject: [PATCH] Add test_history_update --- test/unit/data/data_access/__init__.py | 2 +- test/unit/data/data_access/conftest.py | 2 ++ test/unit/data/data_access/test_misc.py | 21 ++++++++++++++++++++- 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/test/unit/data/data_access/__init__.py b/test/unit/data/data_access/__init__.py index 4e6954640931..4aa7a22a7513 100644 --- a/test/unit/data/data_access/__init__.py +++ b/test/unit/data/data_access/__init__.py @@ -17,4 +17,4 @@ def is_private(self, object): def verify_items(items1, length, items2=None): assert len(items1) == length if items2: - assert set(items2) == set(i for i in items1) + assert set(items2) == set(items1) diff --git a/test/unit/data/data_access/conftest.py b/test/unit/data/data_access/conftest.py index 5d5c78ec8c66..18e439b5b425 100644 --- a/test/unit/data/data_access/conftest.py +++ b/test/unit/data/data_access/conftest.py @@ -11,6 +11,7 @@ from galaxy import model as m from galaxy.datatypes.registry import Registry as DatatypesRegistry +from galaxy.model.triggers.update_audit_table import install as install_timestamp_triggers from . import MockObjectStore # utility fixtures @@ -38,6 +39,7 @@ def setup(engine): datatypes_registry = DatatypesRegistry() datatypes_registry.load_datatypes() m.set_datatypes_registry(datatypes_registry) + install_timestamp_triggers(engine) print("\nSETUP CALLED") diff --git a/test/unit/data/data_access/test_misc.py b/test/unit/data/data_access/test_misc.py index 5a7c74e83fcc..ff6335189284 100644 --- a/test/unit/data/data_access/test_misc.py +++ b/test/unit/data/data_access/test_misc.py @@ -21,7 +21,26 @@ def test_username_is_unique(self, make_user): make_user(username="a") -# replacing test_galaxy_mapping.py +def test_history_update(make_history, make_hda, session): + h1 = make_history() + old_update_time = h1.update_time + + hda = make_hda(history=h1, create_dataset=True, sa_session=session) + # history updated due to hda insert + assert h1.update_time > old_update_time + + old_update_time = h1.update_time + hda.name = "new name" + session.add(hda) + session.commit() + # history updated due to hda update + assert h1.update_time > old_update_time + + old_update_time = h1.update_time + hda2 = hda.copy() + assert hda2 + # history NOT updated when hda copied + assert h1.update_time == old_update_time def test_ratings(