From a282e9c1f2a8c0515ee589dc489bf9460b0544b6 Mon Sep 17 00:00:00 2001 From: Nikhil Thomas Date: Sat, 11 Nov 2023 11:15:35 -0800 Subject: [PATCH] zstd_decompress_by_file should default to true Summary: Changing the default for saved state loading. Reviewed By: ljw1004 Differential Revision: D51213201 fbshipit-source-id: c6fee12d5a4cb78b3b384a2491574a3fe5216820 --- hphp/hack/src/options/globalOptions.ml | 2 +- hphp/hack/src/oxidized/manual/global_options_impl.rs | 2 +- hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hphp/hack/src/options/globalOptions.ml b/hphp/hack/src/options/globalOptions.ml index 3588561300bbcb..5a9022956e660e 100644 --- a/hphp/hack/src/options/globalOptions.ml +++ b/hphp/hack/src/options/globalOptions.ml @@ -35,7 +35,7 @@ let default_saved_state_loading = saved_state_manifold_api_key = None; log_saved_state_age_and_distance = false; use_manifold_cython_client = false; - zstd_decompress_by_file = false; + zstd_decompress_by_file = true; } type saved_state = { diff --git a/hphp/hack/src/oxidized/manual/global_options_impl.rs b/hphp/hack/src/oxidized/manual/global_options_impl.rs index 4b8a743eb3419d..057aeb269bddaa 100644 --- a/hphp/hack/src/oxidized/manual/global_options_impl.rs +++ b/hphp/hack/src/oxidized/manual/global_options_impl.rs @@ -19,7 +19,7 @@ impl Default for SavedStateLoading { saved_state_manifold_api_key: None, log_saved_state_age_and_distance: false, use_manifold_cython_client: false, - zstd_decompress_by_file: false, + zstd_decompress_by_file: true, } } } diff --git a/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs b/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs index 4eb1f8d2251279..4d99a2ccc3fa25 100644 --- a/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs +++ b/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs @@ -15,7 +15,7 @@ const DEFAULT_SAVED_STATE_LOADING: SavedStateLoading<'_> = SavedStateLoading { saved_state_manifold_api_key: None, log_saved_state_age_and_distance: false, use_manifold_cython_client: false, - zstd_decompress_by_file: false, + zstd_decompress_by_file: true, }; const DEFAULT_SAVED_STATE: SavedState<'_> = SavedState {