From f7d0f08ee6743cf1ed147b585764cc3b7154e65c Mon Sep 17 00:00:00 2001 From: John DeRegnaucourt Date: Mon, 12 Feb 2024 21:25:25 -0500 Subject: [PATCH] JDK 1.8 handles IEEE 754 differently than later JDKs. Finding issues with JDK from Maven Central. Committing because I cannot repeat these floating point bugs locally with JDK 1.8 -> 21. --- .../util/convert/ConverterEverythingTest.java | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/test/java/com/cedarsoftware/util/convert/ConverterEverythingTest.java b/src/test/java/com/cedarsoftware/util/convert/ConverterEverythingTest.java index c21ed76b..5cfabae6 100644 --- a/src/test/java/com/cedarsoftware/util/convert/ConverterEverythingTest.java +++ b/src/test/java/com/cedarsoftware/util/convert/ConverterEverythingTest.java @@ -1391,7 +1391,7 @@ public TimeZone getTimeZone() { { Float.MIN_VALUE, "1.4E-45" }, { -Float.MAX_VALUE, "-3.4028235E38" }, { Float.MAX_VALUE, "3.4028235E38" }, - { 123456789f, "1.23456792E8" }, + { 12345679f, "1.2345679E7" }, { 0.000000123456789f, "1.2345679E-7" }, { 12345f, "12345.0" }, { 0.00012345f, "1.2345E-4" }, @@ -1689,15 +1689,10 @@ void testConvert(String shortNameSource, String shortNameTarget, Object source, Object actual = converter.convert(source, targetClass); try { assertEquals(target, actual); - } - catch (Throwable e) { - throw new RuntimeException(e); + } catch (Throwable e) { + System.err.println(shortNameSource + "[" + source + "] ==> " + shortNameTarget + "[" + target + "] Failed"); + throw e; } } } - - @Test - void testStuff() - { - } }