Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action counts modify policy state #8

Open
jdherman opened this issue Jan 3, 2019 · 0 comments
Open

Action counts modify policy state #8

jdherman opened this issue Jan 3, 2019 · 0 comments

Comments

@jdherman
Copy link
Owner

jdherman commented Jan 3, 2019

The idea was for a policy to save its own frequency of actions during a simulation (e.g. "Flood Control (5%)"). However this seems to create a number of problems:

  • During parallelization, the policies themselves need to be returned to master because they are modified when running the objective function

  • After snapshots are saved, if a policy is run again in simulation mode, it does not clear the action count. This results in frequencies that sum to more than 100%. Should be an easy fix.

  • The original goal was to prune actions that never occur. But I never got around to doing that anyway.

I'm wondering if it would be easier to just remove this altogether. Action counts are not a property of the policy anyway, they depend on the forcing scenario. Might be better to leave this up to the simulation model to compute, outside of ptreeopt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant