-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[US-15-4] Give the user the ability to specify an attribute that shouldn't be used for locators generation (Black / Ignore list) #191
Labels
PizzaFeedback
tasks related to user's feedback
ready for dev
task is estimated, described and ready for dev
Milestone
Comments
It is required to resolve this together with #584 (design should be consistent) |
This comment was marked as outdated.
This comment was marked as outdated.
Backend part is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PizzaFeedback
tasks related to user's feedback
ready for dev
task is estimated, described and ready for dev
It makes sense to complete #950 beforehand
Give user a possibility to specify attributes which shouldn't be used for locators generation
As a user
AND some additional attributes are used in my project, which data has no meaning or is useless in locators generation
I want to not generate code on it
So that allows me to get the correct code
DESCRIPTION:
User starts the locators generation and they see that in one of the locators undesired attribute is used. It is required to give user ability to exclude this attribute from locators generation so after locators recalculation new locators wouldn't contain that undesired attribute.
DEPENDENCIES:
#950 - Filter refactoring
#1285 - data-attributes
#1359 - data-ved
ACCEPTANCE CRITERIA
DESIGN:
figma
Additionally, we can separately open the filter and manually specify the attributes that should not be used.
Validation:
COMMENTS:
Changes will be needed on both the front-end and back-end. Currently, the list of attributes is not being transmitted. Because of this, Robula considers all possible combinations.
The fourth option was chosen (the third is also possible), as attribute settings should be made when working with locators, i.e., within an open PO.
Changing an attribute is not a modification, but rather an edit, similar to changing the locator type or switching from xpath to css.
List of attributes: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes
@AlexeyGirin deletion of an attribute from filters will require recalculation of all locators
The text was updated successfully, but these errors were encountered: