Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate resamplers #14

Open
jdisanti opened this issue Aug 28, 2023 · 0 comments
Open

Evaluate resamplers #14

jdisanti opened this issue Aug 28, 2023 · 0 comments

Comments

@jdisanti
Copy link
Owner

The current implementation is using Rubato's SincFixedIn asynchronous resampler with linear interpolation. There are a few other options, such as FftFixedIn, and FastFixedIn. The differences between them seem to be the algorithm, and whether or not you can change the frequency ratio after creating the resampler (which is a feature that isn't needed here).

I'm not sure if SincFixedIn is the best choice for this use case or not. Criteria to scrutinize are efficiency and output quality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdisanti