Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Checkstyle tooling API vs Parsing output #353

Closed
sbreakey opened this issue Oct 8, 2023 · 2 comments
Closed

Question: Checkstyle tooling API vs Parsing output #353

sbreakey opened this issue Oct 8, 2023 · 2 comments

Comments

@sbreakey
Copy link

sbreakey commented Oct 8, 2023

This isn't an issue, just a curiosity I have.

Looking at the implementation of this plugin, it looks pretty advanced, interacting with the Checkstyle tooling API and language server etc.

Looking at one of the other plugins, e.g. https://github.com/thomdabeast/java-checkstyle-vscode
It seems to be implemented in a much simpler, perhaps more naive, way. It basically just executes the checkstyle jar with java -jar and a bunch of arguments, and then parses the output to generate warnings.

Is there an inherent disadvantage to this perhaps more naive approach?

EDIT:
An advantage of the naive approach that I can see is that things like the suppressions functionality (as requested here #335) would work out of the box I think.

@sbreakey
Copy link
Author

sbreakey commented Oct 8, 2023

I see this kind of thing belongs in gitter. Will move there.

@sbreakey sbreakey closed this as completed Oct 8, 2023
@jdneo
Copy link
Owner

jdneo commented Oct 9, 2023

Moved to #355, let's discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants