Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisend Issue with Not Signing Second TX - v0.9.23 #152

Open
davestaxcp opened this issue Jul 31, 2023 · 5 comments
Open

Multisend Issue with Not Signing Second TX - v0.9.23 #152

davestaxcp opened this issue Jul 31, 2023 · 5 comments

Comments

@davestaxcp
Copy link

davestaxcp commented Jul 31, 2023

Some users are experiencing an issue where a Multisend fails on the second Signing of Transaction in v0.9.23
These sends do not include subassets (if that matters)

Some solutions I have seen that may help is:

  • Changing the BTC fee (something custom but near the wanted fee)
  • Sending less assets in the multisend (10 or less)
  • Refreshing Freewallet (to the latest BTC block if left open for some time) and trying again
  • Restarting Freewallet and trying again

Some other issues that may be related to this one if I was to start theorizing ...

  • Users have reported an error trying to use multi send with Trezor hardware wallets and in one circumstance had an issue using the multisend function while having a separate hardware address imported into Freewallet. May not be related but thought I would include the data.

Another thing to note here is less users have reported multisend issues with the prior version (0.9.22) regarding the "Not Signing Second TX" issue

So it may also help to downgrade to 0.9.22 for a very large single multisend

@davestaxcp
Copy link
Author

@oskgie on Telegram mentioned: have unadded the trezor addresses like you suggested... and everything works now. just sent >100 cards from my normal address via multisend successfully.

Wow is the trezor hardware addresses import related here??

@B0BSmiths
Copy link

I can confirm multisend does not work with Trezor. The second part of the p2sh is not signed correctly. As the Trezor device does not speak Counterparty it is not aware of the signatures required on the encoded inputs

@subterranean1
Copy link

Yesterday (1/24/24) using Version 0.9.25 AND 0.9.26 I got an error when attempting to do a multi-send. FW would broadcast the first transaction but then would send an error message during transaction 2. BTC got sent to a random address each time which I presume is lost forever. I attempted the multi-send 4 times. Twice on a laptop with no hardware wallet addresses and twice on a Windows desktop that DOES have hardware addresses imported.

I did not capture all the errors, but here are two:

Error validating transaction: Error running script for input 0 referencing bd58ff9e65feb25f57033b4ef5ddaf58e5189c033996edb591cac234fec55af7 at 0: scriptsig not push only for P2SH.

Error validating transaction: Rejected script for input 0 referencing dd66b8bce0ddc86a9a4cce7603ab8d78a57ce48c1bfa2dcf5d8767903fd62632 at 0..

@jdogresorg
Copy link
Owner

I can confirm multisend does not work with Trezor.

@B0BSmiths Correct, I will be adding MPMA support for trezor in the future... just need to update the code a bit so that we handle signing the second tx... Javier and I will dig into this when we have some time.

Yesterday (1/24/24) using Version 0.9.25 AND 0.9.26 I got an error when attempting to do a multi-send.

@subterranean1 FYI, the outputs in MPMA tx1 are still signable/spendable... not random... so, even if you generate part 1 of a 2 part MPMA tx, then part 2 fails... you are still able to gather/collect all the dust from those part1 txs.

Currently no tool exists to find these failed half-way-done MPMA sends and gather the dust up, but its technically possible, and i'm sure tools will be built in the future to provide the ability to gather dust with a few clicks.

TLDR, your not losing any BTC to "random" addresses... any addresses generated in an MPMA tx1 are spendable / signable.

@subterranean1
Copy link

subterranean1 commented Jan 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants