Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #743

Closed
sgarfinkel opened this issue Jul 30, 2023 · 9 comments
Closed

Windows Support #743

sgarfinkel opened this issue Jul 30, 2023 · 9 comments

Comments

@sgarfinkel
Copy link

sgarfinkel commented Jul 30, 2023

Hi! I really love RTX, but wished it had a working Windows version. Since this is a rust project, in theory it can be cross-compiled Windows.

The main issue would probably be getting the hooks to work with PowerShell. https://github.com/Schniz/fnm has a working integration with PowerShell and could be used as inspiration.

@jdx
Copy link
Owner

jdx commented Jul 31, 2023

There is a discussion about this: #66

@sgarfinkel
Copy link
Author

Interesting thread. I think this is relevant too: https://devblogs.microsoft.com/scripting/proxy-functions-spice-up-your-powershell-core-cmdlets/. I think it’s sufficient if rtx is called anytime someone runs the Set-Location commandlet (cd is an alias for this). RTX could easily proxy that.

@jdx
Copy link
Owner

jdx commented Jul 31, 2023

modifying the behavior of cd is not how rtx works for other shells. Please read the readme to understand how it functions.

@jdx
Copy link
Owner

jdx commented Jul 31, 2023

actually reading the readme again I see this isn't clear, I'll fix that. Meanwhile this is the relevant section: https://github.com/jdxcode/rtx#what-does-rtx-activate-do

@sgarfinkel
Copy link
Author

In that case I’ll have to read about how oh-my-posh works, probably a similar approach would be needed for rtx

@sgarfinkel
Copy link
Author

@f0ff886f
Copy link

f0ff886f commented Nov 7, 2023

It looks like perhaps the recent support for Powershell in direnv can provide a useful starting point for rtx to support Powershell too: https://github.com/direnv/direnv/pull/1171/files#diff-0ae809380696f548da1b4494718ec87231367232b99ca0c9472021f95645e1d3

@jcrben
Copy link

jcrben commented Dec 28, 2023

maybe just focus on the git-for-windows bash (https://github.com/git-for-windows) or msys2 bash (https://github.com/msys2) to start? asdf currently doesn't support "git-bash" (see asdf-vm/asdf#450 ) but a lot of tools do so it may take a bunch of work.

note that I haven't tried it in git bash recently but msys2 supports a lot of linux tools w/ a pacman package manager included. git-for-windows bundles msys2 bash I believe (altho some of the tools it includes may be of the mingw variety)

@jdx
Copy link
Owner

jdx commented Jan 25, 2024

I'm going to direct the conversation to the discussion #66 to try to keep fewer open issues since this isn't something I have any plans to tackle on any timeframe

@jdx jdx closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Repository owner locked as off-topic and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants