Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to ManyToManyField appear later in subsequent version #93

Open
gitanupam opened this issue Jun 1, 2017 · 1 comment
Open

Changes to ManyToManyField appear later in subsequent version #93

gitanupam opened this issue Jun 1, 2017 · 1 comment

Comments

@gitanupam
Copy link

gitanupam commented Jun 1, 2017

Thanks for this project! Super helpful.

After setting it up for my project and running a few test runs, I noticed that if there is a change in a ManyToManyField, it appears in the subsequent version (and not in that version).

For example:

If the model has 3 fields:

name = models.CharField(max_length=200)
section = models.CharField(max_length=200)
area = models.ManyToManyField(Area, blank=True, db_index=True)

And we make the edits in 4 iterations:

Version 1: original
Version 2: name changed
Version 3: name and area changed
Version 4: section changed

On comparing version 1 and 2, I see the name changed (expected)
On comparing version 2 and 3, I see the name changed (unexpected - since area was also changed)
On comparing version 3 and 4, I see the section and the area changed (unexpected - since area was actually changed in the previous revision)

This is happening with all ManyToManyFields.

Is this a known issue? (not sure if the issue is with django-reversion or django-reversion-compare)

@gitanupam
Copy link
Author

I also see the following warning at the end of the comparisons:
Fields/entries marked with * are not under reversion control. It may be that not all marked information are correct.

It seems * is marked only for ForeignKey fields and ManyToManyFields. If thats the original issue, do I have to do something to make bring those under reversion control as well?

@gitanupam gitanupam changed the title Changes to ManyToManyField appear in the subsequent versions Changes to ManyToManyField appear in the subsequent versions only Jun 1, 2017
@gitanupam gitanupam changed the title Changes to ManyToManyField appear in the subsequent versions only Changes to ManyToManyField appear later in subsequent version Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant