Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ultraboss77 mobile panel #42

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

Ultraboss77
Copy link

Description

Suggested changelog entry

Related issues/external references

Implement mobile panel

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the GNU.
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added MD documentation for the sniff.

@zoic21
Copy link
Contributor

zoic21 commented Aug 2, 2024

Bonjour,
Merci pour le pr mais il n'est pas bon, sur la version mobile il ne faut pas de fichier php sinon ca pose soucis lors de la mise en cache et ralenti l'affichage de celle ci.

@Ultraboss77
Copy link
Author

Même en incluant le bout de code php directement dans le fichier html ?

@zoic21
Copy link
Contributor

zoic21 commented Aug 2, 2024

Non non regarde bien partout ya jamais un bout de php pour la version mobile. Ca permet de charger tous les fichiers en cache directement sur le téléphone et donc ensuite juste des échanges Ajax.

@Ultraboss77
Copy link
Author

Ok donc soit solution simple, je garde juste l'inclusion sur Tout et le Coordinateur, ou je trouve un moyen de coder cette fonction en js dans le core ou mobile.

@zoic21
Copy link
Contributor

zoic21 commented Aug 5, 2024

La faut faire toute la partie Ajax qui renvoi la liste des Device pour l'inclusion et construire la liste comme ca sans passer par du php.

Ou autre choix qui m'arrange plus c'est rendre l'interface desktop compatible mobile (ca sera de toute façon une grosse partie du boulot en 4.6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants