Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getty Images #17

Open
andrewhughey opened this issue Mar 7, 2014 · 5 comments · May be fixed by #18
Open

Getty Images #17

andrewhughey opened this issue Mar 7, 2014 · 5 comments · May be fixed by #18

Comments

@andrewhughey
Copy link

I'd love to see the new embedded Getty Images (http://www.bjp-online.com/2014/03/getty-images-makes-35-million-images-free-in-fight-against-copyright-infringement/) work responsively,

@jeffehobbs
Copy link
Owner

@andrewhughey Me too -- literally looking into this right now. What's interesting about these embeds is that each individual one is potentially a different aspect ratio. So, math. :)

@andrewhughey andrewhughey linked a pull request Mar 8, 2014 that will close this issue
@andrewhughey
Copy link
Author

Ah, missed your comment earlier. I gave it a shot with pull request #18.

@jeffehobbs
Copy link
Owner

@andrewhughey check the http://embedresponsively.com/ site. If this solution works for you I'll check it into the main branch.

@andrewhughey
Copy link
Author

It resizes down responsively just fine, but it also resizes up well above the image's actual dimensions.

Any reason you're keeping the height/width attributes in the iframe element?

@jeffehobbs
Copy link
Owner

@andrewhughey In general, I try to keep the original embeds as intact as possible and just wrap them in a div. Having said that, it might be beneficial to impose a schema (http) and lose the w/h attributes. Let me think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants