Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIFH-Vol3-Core not compilable (in VS2012) #30

Closed
tomseidel opened this issue Jan 3, 2016 · 4 comments
Closed

AIFH-Vol3-Core not compilable (in VS2012) #30

tomseidel opened this issue Jan 3, 2016 · 4 comments
Assignees
Labels

Comments

@tomseidel
Copy link

Bought the book Vol3 and tried to use the examples. However I cant compile the source-code with VS2012 While getting errors for:

RandomMOdelSelection.cs:
"public IGenerateRandom Random { get; set; } = new MersenneTwisterGenerateRandom();"

ResilientPropagation.cs:
"public double LastError { get; private set; } = 1.0;"

BoltzmannMachine.cs:
"public override double[] LongTermMemory => new double[0];"

Thanks for helping out.
Thomas

@jeffheaton jeffheaton changed the title AIFH-Vol3-Core not compilable AIFH-Vol3-Core not compilable (in VS2012) Jan 3, 2016
jeffheaton added a commit that referenced this issue Jan 3, 2016
@jeffheaton
Copy link
Owner

I just checked in some changes that will make the code compile in VS2012. I still want to check out a few more things before closing this issue. I did not realize I had broken VS2012 comparability, thank you for bringing that to my attention. Also thank you for buying the book!

@tomseidel
Copy link
Author

Thanks Jeff for the quick fix. Not sure thou whether everthing works as intended.
For instance after trying "LearnDigitsConv", the code goves me no improvements after each iteration on the validation error. Is that inteded for this sample?

image

Also the "LearnDigitsBackprop" does not converge to something meaningful after those 5 iterations.

Thanks for the great work anyway!

@jeffheaton
Copy link
Owner

That does not sound right, I am looking into that!

@jeffheaton jeffheaton added the bug label Jan 6, 2016
@jeffheaton jeffheaton self-assigned this Jan 6, 2016
@jeffheaton
Copy link
Owner

This is related to a similar issue that I've been looking into, see issue #31 for more details. I am going to close this issue, as comparability with VS2012 has been restored. I am also going to update the readme files to indiciate that VS2012 is the minimally supported version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants