Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaceman Diff? #162

Open
jeffkaufman opened this issue Jul 28, 2019 · 4 comments
Open

Spaceman Diff? #162

jeffkaufman opened this issue Jul 28, 2019 · 4 comments

Comments

@jeffkaufman
Copy link
Owner

It might be nice to use https://github.com/holman/spaceman-diff if available to display image diffs

@jeffkaufman
Copy link
Owner Author

@jeffkaufman
Copy link
Owner Author

These would just display the images. If we want to actually diff them that's a lot more work.

@nifr
Copy link

nifr commented Aug 25, 2019

https://github.com/eliukblau/pixterm might be another option :)

  • written in go
  • quite configurable
  • provides binary releases

Thanks for icdiff btw. awesome tool!

@jeffkaufman
Copy link
Owner Author

If anyone feels like adding this, I think a good way to do it would be to have icdiff check if TIV / spaceman-diff / termpix / pixterm etc is available, and if so call out to them for image diffing instead of python's difflib. We can use https://docs.python.org/3/library/imghdr.html (which goes back to python 2.5) to see if something is an image by checking its magic bytes (better than going by extensions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants