cmd/doctor: Remove duplicate source paths from conflicting_urls check #9333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @iBug, My stand on this PR is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
If a single source file is somehow duplicated in Jekyll's build pipeline, it irritates
jekyll doctorto complain aboutConflict: The following destination is shared by multiple files, which doesn't make much sense.This isn't normally possible, but my workaround for a missing feature for the
jekyll-feedplugin relies on this. Nevertheless, it's nice to have as an extra sanity check to remove the duplicates.Context
This PR is one way to fix jekyll/jekyll-feed#390.