Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed name missing #394

Open
wrycu opened this issue Nov 11, 2023 · 6 comments
Open

Feed name missing #394

wrycu opened this issue Nov 11, 2023 · 6 comments

Comments

@wrycu
Copy link

wrycu commented Nov 11, 2023

It appears that the feed name is not being picked up by e.g. inroreader despite the site having both a name and a title. From the debugging I've done, it may be due to the fact that the name is placed into HTML divs, resulting in it being removed during sanitization. In any case, though, not having the name show up in one of the more popular feed readers is something I figured you may want to know.

@Jmuccigr
Copy link

FYI, mine is just fine in Inoreader. It even picks up the subtitle. The title gets wrapped in <title type="html"></title>. For comparison, NetNewsReader picks your title up just fine.

Seems like a bug in Inoreader. What happens if you put in a subtitle via a description in the config? That's the only difference with mine apart from the version of jekyll.

@wrycu
Copy link
Author

wrycu commented Dec 31, 2023

Thanks for the comment! Can you expand on what you mean by "put in a subtitle via a description"?

@Jmuccigr
Copy link

Jmuccigr commented Jan 1, 2024

Thanks for the comment! Can you expand on what you mean by "put in a subtitle via a description"?

In your _config.xml, add a line like this:

description: This is my blog.

The should result in a <subtitle>This is my blog.</subtitle> getting added to your feed.xml once GitHub processes it, which you can then check for.

Again, I have no idea if this is the issue.

PS I'm picking up this as your favicon from one line in your default.html, even though the other icon references refer to the favicon files:

<link rel="mask-icon" href="/assets/images/favicon/safari-pinned-tab.svg" color="#5bbad5">

@Jmuccigr
Copy link

Any luck?

@wrycu
Copy link
Author

wrycu commented Jan 12, 2024

Nope, is still shows <div>Leetsaber</div> when I first follow it and then nothing after in the actual menu.

Edit: thanks for the icon note, I have yet to fix it
Edit 2: I made edits directly to the file, not checked into Github. They're live here - https://leetsaber.com/feed.xml

@Jmuccigr
Copy link

Yeah, the feed now looks just like mine, so I suspect this is a bug in inoreader. Again, the title shows up just fine in the NewNewsWire app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants