-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to skip meta tag generator #404
base: master
Are you sure you want to change the base?
Conversation
👍 I would also like this option. |
@DirtyF can you help this PR |
I like to have this option. But I prefer something more general which allows you to disable any of generated tags. Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -3,7 +3,9 @@ | |||
<title>{{ seo_tag.title }}</title> | |||
{% endif %} | |||
|
|||
{% unless site.skip_generator %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change it by
{% unless seo_tag.skip_generator %}
It's more general
Unit tests must be also provided to check right working jekyll-seo-tag/spec/jekyll_seo_tag_integration_spec.rb Lines 22 to 31 in 93c664b
jekyll-seo-tag/spec/jekyll_seo_tag_integration_spec.rb Lines 299 to 313 in 93c664b
|
Should we simply leave out the generator tag completely? |
Any solution on this? |
Follow-up, PR: #481 |
With this option we allow the dev choose if they wanna show this meta tag or not