-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to files starting with _site are not being picked up #22
Comments
This is because we're using regexp and have no special handling. I'd love to make this more like .gitignore |
If someone sees this and wants to fix it, check out Listen's ignore directive. Right now we use regexp that basically just does a substring lookup. |
I just forked this thing and tinker around a bit. I see that Somehow, I currently run into a regeneration loop as soon as I touch a file that is not ignored. |
Seems a little bit more complicated. I'm not sure how the can tell listen to ignore a directory. Can we distinguish between files and directories? Files would need something like |
I also stumbled over this rather mean bug. My workaround is to export to |
This issue has been automatically marked as stale because it has not been commented on for at least The resources of the Jekyll team are limited, and so we are asking for your help. If you can still reproduce this error on the If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced Thank you for all your contributions. |
Yeah, this has never been fixed. Last time I tried, it still wasn’t working. |
@kleinfreund Thanks for the reply! This may simply be a limitation of the way jekyll-watch works. Would it be enough to indicate |
I don't think so. I worked on that a while back but eventually got stuck. Basically, the root |
This issue has been automatically marked as stale because it has not been commented on for at least one month. The resources of the Jekyll team are limited, and so we are asking for your help. If you can still reproduce this error on the If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open. Thank you for all your contributions. |
Chiming to add my "me too". Just ran across this with a Jekyll template that I've been working with. |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
Adding a "me too". This bit me and killed some time figuring out. |
I stumbled across the same issue and spent nearly 3 hours figuring out what was going on. Basically I had excluded a file called 'start' long ago. Today I created a folder called 'getting-started' and noticed that jekyll-watch was ignoring it during incremental builds. After lot of investigation, I stumbled upon this thread and figured out the problem. Is there a way to specify an exact match instead of a substring match in the exclude list? |
This issue is not resolved. It needs to reopened. |
Anchoring the regexp should help here. |
@kleinfreund et al, Would you guys be willing to test a fix for this..? Simply, add the following to your # Gemfile
gem "jekyll-watch" , :git => "https://github.com/ashmaroli/jekyll-watch.git", :branch => "ignore-directory-paths" |
Apologies for the late response. I'm willing to test it. But can you explain how the fix is going to work so that I know what to test? |
@deepfriedbrain You can start by testing if your issue is resolved.. i.e., if you exclude a 'file' called Then you can test if the plugin ignores changes to a file with the relative-path |
It seems to be working well based on my testing. |
The process of creating a relative path from an absolute one seems to strip the trailing slash, identifying a path as a directory not a file. When this is converted into a Regex for adding to the ignore list, it also ignores files that start with the same name as ignored directories. This fix simply checks whether there was originally a trailing slash, then adds it again before it is converted into a regular expression.
…aseurl * _Gemfile.lock_ - Bundle update. `bundle install --full-index` did not * work. Had to individually update the gems (_listen_, and _jekyll-watch_) * which threw out the "... revealed dependencies not in the API or the * lockfile..." error during `bundle install`. * Updated `_layouts\compress.html` to * [v3.0.4](https://github.com/penibelst/jekyll-compress-html/releases/tag/v3.0.4) * (removed _p_, _rt_, and _rp_ from default endings list). * Renamed `assets\_sass\_site.scss` -> `assets\_sass\_main-site.scss` * because filenames beginning with `_site` are [not picked * up](jekyll/jekyll-watch#22) by * [jekyll-watch](https://github.com/jekyll/jekyll-watch). One possible * [workaround](jekyll/jekyll-watch#22 (comment)). * Changed `site.url` to `site.baseurl` in accordance with [this * comment](https://stackoverflow.com/questions/27386169/change-site-url-to-localhost-during-jekyll-local-development#comment43303379_27400343). * The changes were made in `_includes/head.html`, `_includes/scripts.html` * and `_layouts/home.html`.
Was this fixed? Can the issue be closed? |
@kleinfreund not yet, #65 is still pending for review |
I noticed that changes to files starting with
_site
are not being picked up by Jekyll when usingjekyll s
. Namely, I have the following file names. When I save one of them, the changes are not being picked up by Jekyll._sass/_site-head.scss
_sass/_site-logo.scss
_sass/_site-nav.scss
_includes/_site-head.html
The text was updated successfully, but these errors were encountered: