Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore directories rather than all similar paths #65

Merged
merged 4 commits into from
Nov 10, 2018
Merged

Ignore directories rather than all similar paths #65

merged 4 commits into from
Nov 10, 2018

Conversation

ashmaroli
Copy link
Member

Fixes #22

@DirtyF DirtyF requested a review from a team October 16, 2018 15:09
@DirtyF DirtyF added the fix label Oct 16, 2018
@DirtyF DirtyF mentioned this pull request Oct 16, 2018
Closed
DirtyF
DirtyF approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from the tests :)

@DirtyF DirtyF requested a review from a team October 17, 2018 14:30
parkr
parkr reviewed Oct 17, 2018
View reviewed changes
spec/spec_helper.rb

def ignore_path?(patterns, path)
path = path.to_s
patterns.each do |pattern|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patterns.any? {|pattern| path =~ pattern } might be more concise here

@DirtyF
Copy link
Member

DirtyF commented Nov 10, 2018

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit baf5903 into jekyll:master Nov 10, 2018
@jekyllbot jekyllbot added the bug label Nov 10, 2018
jekyllbot added a commit that referenced this pull request Nov 10, 2018
@jekyllbot
Update history to reflect merge of #65 [ci skip]
91d46df
@ashmaroli
Copy link
Member Author

Uh oh.. I never saw Parker's review until now..

@jekyll jekyll locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr left review comments

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to files starting with _site are not being picked up
4 participants
@ashmaroli @DirtyF @parkr @jekyllbot