-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add watch_exclude setting to _config.yml #91
base: master
Are you sure you want to change the base?
Conversation
7e4c188
to
2eef38d
Compare
The method |
@ashmaroli Understandable, but I don't think it'd be very reliable. What about the annoying edge cases where a person supplies perfectly valid fnmatch arguments, but the regex it produces backtracks and then just hangs forever (I'm not sure whether there's a way to detect and prevent that). Honestly I think jekyll should've made Another, slightly nicer option, would be to add an option to the listen library where it can take a callable for If all that's impossible, then we do still have the option of simply using fnmatch in our I still think a new config option is the nicest way to do this, but that last approach is the second best :). |
I like the second-best option more.. Will you be able to submit a separate PR towards that idea..? |
Yep, I'll submit sometime later today 😄. Do you want me to remove the |
Lets leave this PR as it is.. |
Sorry, got distracted with another project. Anyways see #92. |
see issue #90