-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gemoji parser to parse raw unicode emoji input into token form #38
base: master
Are you sure you want to change the base?
Conversation
Added gemoji parser to parse raw input unicode emoji into token form so that it can be emojified into image.
Nice. I think that's a great addition. We'll likely want to add a test here, just for sanity's sake. @jekyll/ecosystem any strong feelings one way or the other? |
Ideally that should be configurable and there should a method to bypass it on a one-off basis. |
This isn't a library so the latter is not relevant to this matter and it over complicates the facts: You installed this plugin therefore you want emoji's, and if you don't then don't use it. I do like the idea of having an option to disable it entirely though. |
@envygeeks There might be edge cases, e.g. a post about Unicode emojis :) |
👎 on configuration for controlling the unicode emoji parser. 👍 on the option to disable the unicode parser on a per post basis. (perhaps specific front matter on a post) |
I think there should be a liquid tag |
Your latest suggestion is way out of scope for this @spudowiar lets not get crazy. That said, I'm still 👎 on one-off, if you want emoji then use it, otherwise disable the unicode support entirely. The problem with one-off is that it becomes every-off by one-off because of us programmers this will get in the way of. So we are just over-complicating the logistics of what will probably end up happening at the end anyways for most people who use our stuff. |
Let me be clear though, either way this goes I'm happy if it can just be disabled because every one of my posts has code in it and this would instantly start breaking stuff for me since I'm an enforced keyword fanatic so |
@envygeeks I don't think AFAICT |
As of the latest release, that is correct. |
@benbalter It's been that way for a while AFAIK, but there was a regression recently |
Yep See. #37 |
That's not a regression. That's a flag out bug. |
I'm not wild about the idea of an extra dependency here. @cupnoodle, what is the advantage of this over just serving the unicode bytes in the output file? @benbalter Do you know why the emoji filter in html pipeline doesn't do this already? Would it be useful there? |
I don't. @jch any strong feelings one way or the other for converting unicode emoji to GitHub-style emoji either here, or in HTML pipeline itself? |
@parkr Originally I was annoyed that the unicode emoji won't show on unsupported operating system, the advantage of this is that the author can input emoji without referring the cheatsheet and the reader can view the emoji even on unsupported operating systems. |
Ideally this gem isn't made a hard dependency of |
@benbalter no strong feelings, but I don't want to add additional dependencies on the html-pipeline gem. |
Rationale : Eliminate the need to refer/memorize emoji cheatsheet .
Added gemoji parser to parse raw unicode emoji input into token form so that it can be emojified into image.
Type in unicode emoji (Control + Command + Space in OS X)
And then it get emojified into image