Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gemoji parser to parse raw unicode emoji input into token form #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cupnoodle
Copy link

Rationale : Eliminate the need to refer/memorize emoji cheatsheet .

Added gemoji parser to parse raw unicode emoji input into token form so that it can be emojified into image.

Type in unicode emoji (Control + Command + Space in OS X)

screen shot 2016-03-17 at 4 51 28 pm

And then it get emojified into image
screen shot 2016-03-17 at 4 50 56 pm

Added gemoji parser to parse raw input unicode emoji into token form so
that it can be emojified into image.
@benbalter
Copy link
Contributor

Nice. I think that's a great addition. We'll likely want to add a test here, just for sanity's sake.

@jekyll/ecosystem any strong feelings one way or the other?

@ghost
Copy link

ghost commented Mar 17, 2016

Ideally that should be configurable and there should a method to bypass it on a one-off basis.

@envygeeks
Copy link

This isn't a library so the latter is not relevant to this matter and it over complicates the facts: You installed this plugin therefore you want emoji's, and if you don't then don't use it.

I do like the idea of having an option to disable it entirely though.

@ghost
Copy link

ghost commented Mar 17, 2016

@envygeeks There might be edge cases, e.g. a post about Unicode emojis :)

@mattr-
Copy link
Member

mattr- commented Mar 17, 2016

👎 on configuration for controlling the unicode emoji parser.

👍 on the option to disable the unicode parser on a per post basis. (perhaps specific front matter on a post)

@ghost
Copy link

ghost commented Mar 17, 2016

I think there should be a liquid tag echo which means you could do {% echo "\x01" %} where this wouldn't be interrupted by jemoji

@envygeeks
Copy link

Your latest suggestion is way out of scope for this @spudowiar lets not get crazy. That said, I'm still 👎 on one-off, if you want emoji then use it, otherwise disable the unicode support entirely. The problem with one-off is that it becomes every-off by one-off because of us programmers this will get in the way of. So we are just over-complicating the logistics of what will probably end up happening at the end anyways for most people who use our stuff.

@envygeeks
Copy link

Let me be clear though, either way this goes I'm happy if it can just be disabled because every one of my posts has code in it and this would instantly start breaking stuff for me since I'm an enforced keyword fanatic so hello(world:) just got emoji-fied.

@ghost
Copy link

ghost commented Mar 17, 2016

@envygeeks I don't think jemoji works in code blocks, if it does a) this shouldn't affect that, b) that's another issue

AFAICT gemoji-parser doesn't affect HTML entities so that should be perfect for the edge cases.

@benbalter
Copy link
Contributor

don't think jemoji works in code blocks, if it does a) this shouldn't affect that, b) that's another issue

As of the latest release, that is correct.

@ghost
Copy link

ghost commented Mar 17, 2016

@benbalter It's been that way for a while AFAIK, but there was a regression recently

@benbalter
Copy link
Contributor

It's been that way for a while AFAIK, but there was a regression recently

Yep See. #37

@envygeeks
Copy link

That's not a regression. That's a flag out bug.

@parkr
Copy link
Member

parkr commented Mar 19, 2016

I'm not wild about the idea of an extra dependency here. @cupnoodle, what is the advantage of this over just serving the unicode bytes in the output file?

@benbalter Do you know why the emoji filter in html pipeline doesn't do this already? Would it be useful there?

@benbalter
Copy link
Contributor

Do you know why the emoji filter in html pipeline doesn't do this already? Would it be useful there?

I don't. @jch any strong feelings one way or the other for converting unicode emoji to GitHub-style emoji either here, or in HTML pipeline itself?

@cupnoodle
Copy link
Author

@parkr Originally I was annoyed that the unicode emoji won't show on unsupported operating system, the advantage of this is that the author can input emoji without referring the cheatsheet and the reader can view the emoji even on unsupported operating systems.

@ghost
Copy link

ghost commented Mar 20, 2016

Ideally this gem isn't made a hard dependency of jemoji and only needed if the Unicode transformation is enabled.

@jch
Copy link

jch commented Mar 21, 2016

@benbalter no strong feelings, but I don't want to add additional dependencies on the html-pipeline gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants