Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is 3.0? #656

Open
jiapei100 opened this issue May 18, 2022 · 27 comments
Open

Where is 3.0? #656

jiapei100 opened this issue May 18, 2022 · 27 comments
Labels

Comments

@jiapei100
Copy link

README.md says there is a version 3.0... But, where is such a release or branch ?

@ashmaroli
Copy link
Member

There is no explicit v3.0 branch or release.
The current master is considered as v3.0 even though the gemspec says differently.

@jekyllbot

This comment was marked as resolved.

@getaaron
Copy link
Contributor

Any reason we can't create a 3.0 branch and release?

@jekyllbot jekyllbot removed the stale label Aug 10, 2022
@jekyllbot

This comment was marked as resolved.

@getaaron
Copy link
Contributor

.

@jekyllbot

This comment was marked as resolved.

@dgw
Copy link

dgw commented Dec 10, 2022

Three years since the last tagged release.

Will it ever be time?

@jekyllbot jekyllbot removed the stale label Dec 10, 2022
@goseind
Copy link

goseind commented Jan 29, 2023

I'd also really appreciate a proper release of the newest state! 👀

@jekyllbot

This comment was marked as resolved.

@dgw
Copy link

dgw commented Mar 29, 2023

Someone please exclude this issue from @jekyllbot's staleness check. Until there is a new release, it will never be stale.

@jekyllbot

This comment was marked as resolved.

@getaaron
Copy link
Contributor

.

@jekyllbot jekyllbot removed the stale label May 29, 2023
@Simon-Bakken-Jantasuk
Copy link

Simon-Bakken-Jantasuk commented Jun 11, 2023

😴 Zzzz

@jekyllbot

This comment was marked as resolved.

@dgw
Copy link

dgw commented Aug 11, 2023

*hits the snooze button again*

@jekyllbot jekyllbot removed the stale label Aug 11, 2023
@mattr- mattr- added the pinned label Oct 9, 2023
@ethan-dowler
Copy link

idk if the pinned label will prevent the staleness check, but I'm throwing my hat in the ring as someone who wants 3.0 😁

@bricelam
Copy link

Is there a roadmap of the outstanding work for 3.0? The community might be a little more proactive in helping get it out the door if there were...

@mattr-
Copy link
Member

mattr- commented Oct 31, 2023

For follks that want the 3.0 version of minima, is there something preventing you from using https://github.com/benbalter/jekyll-remote-theme and specifying jekyll/minima as the remote theme? My time and attention is limited and a 3.0 release of minima is very low on my priority list at the moment.

@dgw
Copy link

dgw commented Oct 31, 2023

Are there workarounds? Of course. There's that remote theme plugin, and there's also fetching the gem from GitHub (gem "minima", :github => 'jekyll/minima', :ref => 'commit-ish_here').

But going so long without a release brings into question the maintenance status of this theme, i.e. should we start making plans to migrate onto something else lest a future major Jekyll version update break something?

If 3.0 is "done" and just not tagged, we still must wonder whether maintenance will happen when there isn't even enough bandwidth among the maintenance team to tag a release. And if the work for 3.0 is unfinished, that goes doubly so.

@KarlHeitmann
Copy link
Contributor

Hi!

Some days ago I started a new Jekyl site, I used the jekyl new my_site command using ruby v3.2.2, and when I ran the bundle exec jekyll serve command on my_site root folder, I've got 6 deprecation warnings.

It took me some time to discover the minima 2.5 version was last updated 5 years ago. When I noticed that, I switched to branch master and AFAIS, everything looks good.

What do you need to do the 3.0 release?

I volunteer myself to help you with the 3.0 release. I already submitted a PR #797 to fix a deprecation warning I found on the minima master branch. I can get my hands dirty here, but I'll need some guidelines to do the work properly.

BTW, I am looking for a new job. I am offering myself as a volunteer to do this task because I want to gain experience on doing releases, it is something I've never done before on a popular open source project.

@KarlHeitmann
Copy link
Contributor

I propose to release the version 3.0 as it is.

Just writing a changelog / tag with the breaking changes, fix the deprecation messages and release.

@getaaron
Copy link
Contributor

getaaron commented Aug 9, 2024

It is pretty clear 3.0 will never be released unless someone wants to maintain a fork.

@CodeAsm
Copy link

CodeAsm commented Aug 21, 2024

Just release a 3.0 or something. this makes me sadness

@pjschinske
Copy link

pjschinske commented Nov 18, 2024

I know there's not much point in me asking this, but what's limiting a 3.0 release? Should we consider this project unmaintained? Seems like people have been asking about it for over 5 years now.

@ashmaroli
Copy link
Member

Minima is not unmaintained.

Minima 3.0-dev has some issues that prevent it from being officially released. But users can consume the same via remote-theme plugin, so we don't see the need for a "release" as priority.

@pjschinske
Copy link

I could help with solving issues if you like. Which issues are preventing the 3.0 release?

@ashmaroli
Copy link
Member

@pjschinske The primary issue is that Minima 3.0's social icons have a rendering issue that is flaky. They render as expected at most times yet render as empty boxes sometimes in spite of being configured correctly.

I am in search of a solution that will allow end-users to drop-in SVGs at their source and have Jekyll pick it up. This absolves Minima from having to dictate config keys and bundle necessary assets to render social icons.

A secondary issue is more of an executive decision wherein it's not yet clear if we should embrace Dart Sass syntax wholeheartedly (which would mean causing issues to remote-theme consumers still on Jekyll 3.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests