Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Deprecation warning in minima/_layout.scss file about "mixed-decls" issue. #796

Closed
KarlHeitmann opened this issue Aug 9, 2024 · 1 comment

Comments

@KarlHeitmann
Copy link
Contributor

KarlHeitmann commented Aug 9, 2024

Description

I've started a brand new Jekyl project using minima theme, and changed my Gemfile to target the current minima master branch version (3.0.0.dev) and got a Deprecation warning.

I've investigated a little bit the issue on my project and found out the problem is in this repo.

Below I'll write the ruby version I'm using and the gem versions:

Deprecation message:


Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ╷
83 │ ┌     &:not(:last-child) {
84 │ │       margin-right: 0;
85 │ │     }
   │ └─── nested rule
86 │       margin-left: 20px;
   │       ^^^^^^^^^^^^^^^^^ declaration
   ╵
    minima/_layout.scss 86:5                                                         @import
    minima/initialize.scss 48:3                                                      @import
    /assets/css/style.scss 3:3  root stylesheet
Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
111 │ ┌       &:not(:last-child) {
112 │ │         margin-right: 20px;
113 │ │       }
    │ └─── nested rule
114 │         margin-left: auto;
    │         ^^^^^^^^^^^^^^^^^ declaration
    ╵
    minima/_layout.scss 114:7                                                        @import
    minima/initialize.scss 48:3                                                      @import
    /assets/css/style.scss 3:3  root stylesheet
                    done in 0.338 seconds.

  • ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux]
  • jekyll (4.3.3)
  • minima: current master branch, HEAD pointing to commit 1d5286cf9a1aae34078420d183d560dd673d98b5

Proposal

I've discovered the problem, I'll propose a PR to fix it.

KarlHeitmann added a commit to KarlHeitmann/minima that referenced this issue Aug 9, 2024
jekyllbot pushed a commit that referenced this issue Aug 11, 2024
@ashmaroli
Copy link
Member

Fixed via #797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants