Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jellyfin/jellyfin-plugin-playbackreporting
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8bcc1618e694f2327614ad7c8c4b02fc04011dd1
Choose a base ref
..
head repository: jellyfin/jellyfin-plugin-playbackreporting
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e5215db1027a95c8f5788748905096dbc41d4883
Choose a head ref
Showing with 18 additions and 3 deletions.
  1. +1 −1 Jellyfin.Plugin.PlaybackReporting/Data/IActivityRepository.cs
  2. +15 −1 Jellyfin.Plugin.PlaybackReporting/EventMonitorEntryPoint.cs
  3. +1 −1 README.md
  4. +1 −0 build.yaml
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ You should have received a copy of the GNU General Public License

namespace Jellyfin.Plugin.PlaybackReporting.Data
{
public interface IActivityRepository
public interface IActivityRepository : IDisposable
{
int RemoveUnknownUsers(List<string> known_user_ids);
void ManageUserList(string action, string id);
16 changes: 15 additions & 1 deletion Jellyfin.Plugin.PlaybackReporting/EventMonitorEntryPoint.cs
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ You should have received a copy of the GNU General Public License

namespace Jellyfin.Plugin.PlaybackReporting
{
public class EventMonitorEntryPoint : IHostedService
public class EventMonitorEntryPoint : IHostedService, IDisposable
{
private readonly ISessionManager _sessionManager;
private readonly IServerConfigurationManager _config;
@@ -368,5 +368,19 @@ public Task StopAsync(CancellationToken cancellationToken)

return Task.CompletedTask;
}

public void Dispose()
{
if (_repository != null)
{
_repository.Dispose();
_repository = null;
}
}

~EventMonitorEntryPoint()
{
Dispose();
}
}
}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ This information can be viewed as a multitude of different graphs, and can also

## Build

1. To build this plugin you will need [.Net 5.x](https://dotnet.microsoft.com/download/dotnet/5.0).
1. To build this plugin you will need [.Net 8.x](https://dotnet.microsoft.com/download/dotnet/8.0).

2. Build plugin with following command
```
1 change: 1 addition & 0 deletions build.yaml
Original file line number Diff line number Diff line change
@@ -13,4 +13,5 @@ artifacts:
- "Jellyfin.Plugin.PlaybackReporting.dll"
- "SQLitePCL.pretty.dll"
changelog: |-
- Fix database connection disposal on server shutdown (#98) @a-mnich
- fix nullable warnings (#99) @a-mnich