From d3a58f87152d39c403f8188d414631ecdb4fab8b Mon Sep 17 00:00:00 2001 From: Ratul Date: Sun, 17 Mar 2024 12:05:33 +0530 Subject: [PATCH 1/5] add hover effect to Navbar --- src/jio-navbar-link.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/jio-navbar-link.ts b/src/jio-navbar-link.ts index 997863b..6741b3d 100644 --- a/src/jio-navbar-link.ts +++ b/src/jio-navbar-link.ts @@ -13,6 +13,10 @@ export class NavbarLink extends LitElement { text-decoration: none; transition: color 0.15s ease-in-out, background-color 0.15s ease-in-out, border-color 0.15s ease-in-out; } +.nav-link:hover{ + text-decoration: underline; + color: rgba(255, 255, 255, 0.55); +} .dropdown-item { background-color: transparent; border: 0; From 0edd4f964be7dce108397836c97a53c6033922ed Mon Sep 17 00:00:00 2001 From: Ratul Saha Date: Sun, 17 Mar 2024 19:16:15 +0530 Subject: [PATCH 2/5] add hover effect to Navbar dropdown links --- src/jio-navbar.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/jio-navbar.css b/src/jio-navbar.css index c6a1b6d..79e6fbe 100644 --- a/src/jio-navbar.css +++ b/src/jio-navbar.css @@ -112,6 +112,11 @@ button.nav-link { box-shadow: 0 2px 4px -3px rgb(0 0 0 / 25%); } +.nav-link:hover{ + text-decoration: underline; + color: rgba(255, 255, 255, 0.55); +} + /* FIXME - move to jio-navbar-link */ .nav-link { color: rgba(255, 255, 255, 0.55); From d30e1d147dd369d7f1af6fa54d43ed2be58e9532 Mon Sep 17 00:00:00 2001 From: Ratul Saha Date: Sun, 17 Mar 2024 19:57:33 +0530 Subject: [PATCH 3/5] resolve lint errors --- src/jio-navbar.css | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/jio-navbar.css b/src/jio-navbar.css index 79e6fbe..f4cb5c6 100644 --- a/src/jio-navbar.css +++ b/src/jio-navbar.css @@ -104,6 +104,10 @@ button:not(:disabled) { line-height: inherit; margin: 0 auto; } +/* .nav-link.dropdown-toggle:hover { + text-decoration: underline; + color: rgba(255, 255, 255, 0.55); +} */ button.nav-link { background: #f9f9f9; @@ -111,12 +115,16 @@ button.nav-link { border-radius: 3px; box-shadow: 0 2px 4px -3px rgb(0 0 0 / 25%); } - -.nav-link:hover{ +button.nav-link:hover { text-decoration: underline; color: rgba(255, 255, 255, 0.55); } +/* .nav-link:hover{ + text-decoration: underline; + color: rgba(255, 255, 255, 0.55); +} */ + /* FIXME - move to jio-navbar-link */ .nav-link { color: rgba(255, 255, 255, 0.55); From 9399368f8559de723212d1e73ee2ee00da313cec Mon Sep 17 00:00:00 2001 From: Ratul Saha Date: Mon, 18 Mar 2024 06:12:54 +0530 Subject: [PATCH 4/5] fix errors --- src/jio-navbar-link.ts | 2 +- src/jio-navbar.css | 13 ++----------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/jio-navbar-link.ts b/src/jio-navbar-link.ts index 6741b3d..582a2a1 100644 --- a/src/jio-navbar-link.ts +++ b/src/jio-navbar-link.ts @@ -13,7 +13,7 @@ export class NavbarLink extends LitElement { text-decoration: none; transition: color 0.15s ease-in-out, background-color 0.15s ease-in-out, border-color 0.15s ease-in-out; } -.nav-link:hover{ +.nav-link:hover { text-decoration: underline; color: rgba(255, 255, 255, 0.55); } diff --git a/src/jio-navbar.css b/src/jio-navbar.css index f4cb5c6..a3515e9 100644 --- a/src/jio-navbar.css +++ b/src/jio-navbar.css @@ -104,10 +104,10 @@ button:not(:disabled) { line-height: inherit; margin: 0 auto; } -/* .nav-link.dropdown-toggle:hover { +.nav-link.dropdown-toggle:hover { text-decoration: underline; color: rgba(255, 255, 255, 0.55); -} */ +} button.nav-link { background: #f9f9f9; @@ -115,15 +115,6 @@ button.nav-link { border-radius: 3px; box-shadow: 0 2px 4px -3px rgb(0 0 0 / 25%); } -button.nav-link:hover { - text-decoration: underline; - color: rgba(255, 255, 255, 0.55); -} - -/* .nav-link:hover{ - text-decoration: underline; - color: rgba(255, 255, 255, 0.55); -} */ /* FIXME - move to jio-navbar-link */ .nav-link { From c42ea1346c3eba6dbc7c89e8b19cc01f759e99f3 Mon Sep 17 00:00:00 2001 From: Ratul Saha Date: Mon, 18 Mar 2024 06:45:13 +0530 Subject: [PATCH 5/5] solve linting errors --- src/jio-navbar.css | 1 + 1 file changed, 1 insertion(+) diff --git a/src/jio-navbar.css b/src/jio-navbar.css index a3515e9..a192b9f 100644 --- a/src/jio-navbar.css +++ b/src/jio-navbar.css @@ -104,6 +104,7 @@ button:not(:disabled) { line-height: inherit; margin: 0 auto; } + .nav-link.dropdown-toggle:hover { text-decoration: underline; color: rgba(255, 255, 255, 0.55);